Fix a failed test of ConsoleAdapter - #4477
Merged
Merged
Conversation
Follow the change of the log format as of console v1.24. Signed-off-by: Takuro Ashie <ashie@clear-code.com>
daipom
approved these changes
Apr 30, 2024
daipom
left a comment
daipom
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Thanks for this fix!
Contributor
|
We need to backport this to v1.16 |
daipom
pushed a commit
that referenced
this pull request
May 7, 2024
Backported from a226e28. --- Follow the change of the log format as of console v1.24. Signed-off-by: Takuro Ashie <ashie@clear-code.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes:
N/A
What this PR does / why we need it:
Follow the change of the log format as of console v1.24.
Docs Changes:
N/A
Release Note:
N/A