Repository navigation
fix(media): preserve attachment paths to avoid filename collisions - #5
Merged
freanocank merged 1 commit intoOct 13, 2026
Merged
Conversation
Owner
|
Thanks for the fix and regression tests. Adopted through #15 with your original commits preserved. The collision regressions retain distinct document, video and cache-image payloads. The combined suite passes all four macOS/Windows × Python 3.10/3.13 CI jobs; Windows reports 209 passed, and macOS reports 208 passed with the Windows-only test skipped. |
This was referenced Oct 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The media exporter recursively discovers files but copies them into flat folders using only the basename. Two attachments named
same-namein different source directories are reported as two exports while only one survives. Documents, videos and cache images are all affected.Preserve each file's relative source directory under
docs/,videos/orimages/. Root-level files keep their previous paths, and cache images still receive the detected.jpg/.pngsuffix. Encrypted.datimages continue to be counted and skipped.Validation on macOS / Python 3.12:
python -m pytest -q: 87 passed, 1 skipped.This is an independent CLI export fix; it does not implement encrypted-image decoding or transcript-to-image association. Only synthetic files are used.
The fork CI matrix passed on macOS and Windows with Python 3.10 and 3.13: run 38035161436. The upstream fork-PR workflow still requires maintainer approval.