fix(rna2vec): always append padded sequence when all triplets are unknown#373
Open
maniktyagi04 wants to merge 1 commit intogc-os-ai:mainfrom
Open
fix(rna2vec): always append padded sequence when all triplets are unknown#373maniktyagi04 wants to merge 1 commit intogc-os-ai:mainfrom
maniktyagi04 wants to merge 1 commit intogc-os-ai:mainfrom
Conversation
…re unknown Remove the if any(converted) guard that silently dropped sequences where every overlapping triplet resolved to index 0. Such sequences now produce an all-zero row, preserving 1-to-1 alignment between the input list and the output array. Fixes gc-os-ai#372
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #372
Summary
Remove the if any(converted): guard in rna2vec which caused sequences with all-zero values to be dropped.
This ensures the output always preserves the same number of rows as the input.
Before:
After: