[BUG] fix: sklearn compat shim for validate_data import (closes #365)#374
Open
Blackphoenix-15 wants to merge 2 commits intogc-os-ai:mainfrom
Open
[BUG] fix: sklearn compat shim for validate_data import (closes #365)#374Blackphoenix-15 wants to merge 2 commits intogc-os-ai:mainfrom
Blackphoenix-15 wants to merge 2 commits intogc-os-ai:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Fixes #365
What does this implement/fix? Explain your changes.
Replaces the direct
from sklearn.utils.validation import validate_dataimportwith a compatibility shim that works across sklearn versions:
The shim detects the sklearn version at runtime and defines validate_data accordingly, so the rest of the code works unchanged.
What should a reviewer concentrate their feedback on?
Did you add any tests for the change?
No new tests added. Tested manually by importing pyaptamer.aptanet with sklearn 1.4.0.
Any other comments?
PR checklist
pre-commit install.To run hooks independent of commit, execute
pre-commit run --all-files