[BUG] fix: rna2vec preserves short sequences as zero rows (closes #363)#375
Open
Blackphoenix-15 wants to merge 2 commits intogc-os-ai:mainfrom
Open
[BUG] fix: rna2vec preserves short sequences as zero rows (closes #363)#375Blackphoenix-15 wants to merge 2 commits intogc-os-ai:mainfrom
Blackphoenix-15 wants to merge 2 commits intogc-os-ai:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Fixes #363
What does this implement/fix? Explain your changes.
Removed the
if any(converted):guard inrna2vecthat silently droppedsequences shorter than 3 characters. Short sequences now return a zero-padded
row instead, preserving alignment between x_apta, x_prot, and y in APIDataset.
Before: rna2vec(["AAAA", "AA", "CCCC"], max_sequence_length=5) returned shape (2, 5)
After: rna2vec(["AAAA", "AA", "CCCC"], max_sequence_length=5) returns shape (3, 5)
What should a reviewer concentrate their feedback on?
The removal of the
if any(converted):block in _rna.py and the dedentedtruncate/pad logic that replaces it.
Did you add any tests for the change?
none
Any other comments?
PR checklist
pre-commit install.To run hooks independent of commit, execute
pre-commit run --all-files