Skip to content

[BUG] fix: add missing max_len to GreedyEncoder.get_test_params param0 (closes #376)#377

Open
Blackphoenix-15 wants to merge 3 commits intogc-os-ai:mainfrom
Blackphoenix-15:fix/greedy-encoder-test-params-376
Open

[BUG] fix: add missing max_len to GreedyEncoder.get_test_params param0 (closes #376)#377
Blackphoenix-15 wants to merge 3 commits intogc-os-ai:mainfrom
Blackphoenix-15:fix/greedy-encoder-test-params-376

Conversation

@Blackphoenix-15
Copy link
Copy Markdown

@Blackphoenix-15 Blackphoenix-15 commented Apr 12, 2026

Reference Issues/PRs

Fixes #376

What does this implement/fix? Explain your changes.

Added missing max_len argument to param0 in GreedyEncoder.get_test_params().
The init requires max_len but param0 was not providing it, causing a
TypeError when instantiating GreedyEncoder with param0.

What should a reviewer concentrate their feedback on?

The single line addition of "max_len": 10 to param0 in get_test_params() in _greedy.py

Did you add any tests for the change?

No new tests added. The fix directly resolves the TypeError shown in the issue.

Any other comments?

PR checklist

  • The PR title starts with either [ENH], [MNT], [DOC], or [BUG]. [BUG] - bugfix, [MNT] - CI, test framework, [ENH] - adding or improving code, [DOC] - writing or improving documentation or docstrings.
  • Added/modified tests
  • Used pre-commit hooks when committing to ensure that code is compliant with hooks. Install hooks with pre-commit install.
    To run hooks independent of commit, execute pre-commit run --all-files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] GreedyEncoder.get_test_params() missing required max_len in param0

1 participant