[BUG] seq2vec silently drops unknown characters instead of mapping to index 0#382
Open
rupeshca007 wants to merge 1 commit intogc-os-ai:mainfrom
Open
[BUG] seq2vec silently drops unknown characters instead of mapping to index 0#382rupeshca007 wants to merge 1 commit intogc-os-ai:mainfrom
rupeshca007 wants to merge 1 commit intogc-os-ai:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Fixes #381
What does this implement/fix? Explain your changes.
Fixes a silent data corruption bug in
seq2vecwhere unknown characters were completely dropped from sequences instead of being mapped to the0index token as documented.Changes implemented:
output.append(0)andoutput_ss.append(0)inside the unmatched logic block.seq_max_lenboundary check in the fallback block to ensure chunk resets are correctly maintained.What should a reviewer concentrate their feedback on?
Did you add any tests for the change?
Any other comments?
None.
PR checklist