fix: use IUPAC 'X' instead of 'N' for unknown amino acids#388
Open
neha222222 wants to merge 1 commit intogc-os-ai:mainfrom
Open
fix: use IUPAC 'X' instead of 'N' for unknown amino acids#388neha222222 wants to merge 1 commit intogc-os-ai:mainfrom
neha222222 wants to merge 1 commit intogc-os-ai:mainfrom
Conversation
N (Asparagine) is a valid standard amino acid. Using it as a placeholder for unknown residues is biologically incorrect. IUPAC convention uses X for unknown amino acids. Closes gc-os-ai#328
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
N (Asparagine) is a valid standard amino acid. Using it as a placeholder for unknown residues is biologically incorrect. IUPAC convention uses X for unknown amino acids.
Closes #328
Reference Issues/PRs
What does this implement/fix? Explain your changes.
What should a reviewer concentrate their feedback on?
Did you add any tests for the change?
Any other comments?
PR checklist
pre-commit install.To run hooks independent of commit, execute
pre-commit run --all-files