[BUG] Fix duplicated words in AptaTrans docstring and comment#398
Open
adarshh347 wants to merge 1 commit intogc-os-ai:mainfrom
Open
[BUG] Fix duplicated words in AptaTrans docstring and comment#398adarshh347 wants to merge 1 commit intogc-os-ai:mainfrom
adarshh347 wants to merge 1 commit intogc-os-ai:mainfrom
Conversation
- pyaptamer/aptatrans/_pipeline.py: drop duplicated 'for' in module docstring - pyaptamer/aptatrans/_model.py: drop duplicated 'the' in inline comment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Fixes #397
Follows the same pattern as the previously merged MCTS docstring cleanup (commit
70e63e6).What does this implement/fix? Explain your changes.
Removes two stray word duplications in
pyaptamer/aptatrans/:pyaptamer/aptatrans/_pipeline.pyAptaTrans' complete pipeline for for aptamer-protein interaction prediction andAptaTrans' complete pipeline for aptamer-protein interaction prediction andpyaptamer/aptatrans/_model.py# pass the the encoder a padding mask to ignore zero-padded tokens# pass the encoder a padding mask to ignore zero-padded tokensBoth changes are text-only (one word deletion each). There is no behavioural, API, or import change.
A repo-wide scan for common duplicated-word patterns (
for for,the the,and and,of of,in in,to to,is is,with with,that that,as as) confirmed these are the only remaining occurrences underpyaptamer/.What should a reviewer concentrate their feedback on?
Did you add any tests for the change?
No tests added. The changes are in a module docstring and an inline comment; there is no runtime behaviour to assert. This follows the precedent of commit
70e63e6(MCTS docstring fix), which was merged without tests for the same reason.Any other comments?
Diff summary:
PR checklist
pre-commit run --files pyaptamer/aptatrans/_pipeline.py pyaptamer/aptatrans/_model.pypasses (ruff-format, ruff, mixed-line-ending).