[BUG] Inconsistent pipeline design and missing return type hints in dataset loaders#407
Open
TrishaG189 wants to merge 2 commits intogc-os-ai:mainfrom
Open
[BUG] Inconsistent pipeline design and missing return type hints in dataset loaders#407TrishaG189 wants to merge 2 commits intogc-os-ai:mainfrom
TrishaG189 wants to merge 2 commits intogc-os-ai:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Closes #406
What does this implement/fix? Explain your changes.
While going through the code, I noticed a small inconsistency in how pipelines are implemented:
AptaNetPipelinefollows the sklearn interface (BaseEstimator)AptaTransPipelineis implemented as a regular classI haven’t changed the pipeline behavior here, but wanted to highlight this inconsistency as part of the fix.
Along with that, I added missing return type hints to dataset loaders:
load_1brqload_1gnhThese changes make the code a bit easier to understand and improve IDE support.
What should a reviewer concentrate their feedback on?
Did you add any tests for the change?
No new tests were added since this only involves type hints and minor structural consistency. All existing tests pass.
Any other comments?
Happy to take this further (e.g., making
AptaTransPipelinesklearn-compatible) if that direction makes sense.PR checklist