fix: address best-practice deviations and inconsistencies across features#123
Merged
georglauterbach merged 2 commits intomainfrom Apr 12, 2026
Merged
Conversation
…ures Agent-Logs-Url: https://github.com/georglauterbach/dev-container-features/sessions/eda26b99-e515-4676-998c-d52485b321a1 Co-authored-by: georglauterbach <44545919+georglauterbach@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
georglauterbach
April 12, 2026 18:28
View session
georglauterbach
approved these changes
Apr 12, 2026
Signed-off-by: Georg Lauterbach <44545919+georglauterbach@users.noreply.github.com>
georglauterbach
approved these changes
Apr 12, 2026
Copilot stopped work on behalf of
georglauterbach due to an error
April 12, 2026 18:35
Copilot stopped work on behalf of
georglauterbach due to an error
April 12, 2026 18:39
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Several bugs, a security issue, and minor inconsistencies found during a cross-feature audit of
src/.Bug fixes
lang-shbroken shellcheck rcfile path:DCF_LANG_SH_DIRwas set toghcr.io(dots) in bothdevcontainer-feature.jsonandinstall.sh, whileshellcheck.customArgsalready referencedghcr_io(underscores). The VS Code shellcheck extension would silently fail to load the rcfile at runtime. Aligned toghcr_iothroughout, consistent with all other features.lang-rustREADME: undefined container env variable: Pretty-printing snippet referenced${containerEnv:DCF_LANG_RUST_LLDB_PRETTIFIER}, which is never exported as acontainerEnv.NOTES.md(the source of truth) correctly used${containerEnv:DCF_LANG_RUST_DIR}/lldb_prettifier.py; the README is updated to match.Security
chmod 777on lldb prettifier script:lang-rust/install.shset world-writable permissions onlldb_prettifier.py. Changed to644.Typos / noise
vscode-cache-extensions/README.md: "Fearure" → "Feature"vscode-cache-extensions/install.shcomment: "cary" → "carry"hermes/install.sh: removed a stray# shellcheck disable=SC2154— no variables in that script trigger SC2154