Added DrawGeometryTask

[anandwana001]

Fixes #3148

This PR implements the new DrawGeometry task UI for Android, unifying the "Drop Pin" and "Capture Location" functionalities into a single, configurable task type. This change aligns the Android client with the updated DrawGeometry task model, allowing survey administrators to configure location lock requirements and accuracy thresholds.

Key Changes
Model & Schema:

• Updated Task.Type: Added DRAW_GEOMETRY to the enum.
• Updated Task: Integrated DrawGeometry configuration (including require_device_location and min_accuracy_meters).
• Updated TaskConverter: Mapped DrawGeometry proto messages to Task.Type.DRAW_GEOMETRY, ensuring correct field population from the updated proto definition.

UI Implementation:

• DrawGeometryTaskFragment: A new shared fragment that dynamically adapts its UI:
  • Capture Mode (require_device_location = true): Enforces location lock, disables map panning, and requires accuracy validation before capturing.
  • Drop Pin Mode (require_device_location = false): Allows map panning and pin placement at the camera center (legacy drop pin behavior).
• DrawGeometryTaskViewModel: Manages task state, location updates, and data submission. It correctly generates either CaptureLocationTaskData or DropPinTaskData based on the configuration.
• DrawGeometryTaskMapFragment: Handles map interactions, specifically disabling gestures when location lock is enforced.

Persistence:

• ValueJsonConverter: Updated to handle persistence for DRAW_GEOMETRY tasks, supporting both Point (for drop pin) and CaptureLocation (for full location capture) data formats.

Tests:

• DrawGeometryTaskViewModelTest: Added comprehensive unit tests to verify:
  - Location lock enforcement logic.
  - Correct generation of CaptureLocationTaskData vs. DropPinTaskData.
  - Location lock flow initialization.

Verification
Automated Tests:

• Created and ran DrawGeometryTaskViewModelTest.
• All tests passed successfully, verifying logical correctness and proto compatibility.

Manual Verification:

• Verified the logic and flow of the new ViewModel and Fragment.
• Confirmed that the updated Proto dependency is correctly integrated and fields are accessible.

@shobhitagarwal1612 PTAL?

Screen.Recording.2025-12-27.at.1.48.51.PM.mov

[codecov]

Codecov Report

❌ Patch coverage is 31.50358% with 287 lines in your changes missing coverage. Please review.
✅ Project coverage is 68.19%. Comparing base (68dce1c) to head (724d17b).

Files with missing lines	Patch %	Lines
...lection/tasks/geometry/DrawGeometryTaskFragment.kt	0.00%	117 Missing ⚠️
...ection/tasks/geometry/DrawGeometryTaskViewModel.kt	50.89%	93 Missing and 17 partials ⚠️
...tion/tasks/geometry/DrawGeometryTaskMapFragment.kt	0.00%	52 Missing ⚠️
...id/data/local/room/converter/ValueJsonConverter.kt	33.33%	2 Missing and 4 partials ⚠️
...tform/android/model/submission/GeometryTaskData.kt	66.66%	1 Missing ⚠️
...droid/ui/datacollection/DataCollectionViewModel.kt	0.00%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##             master    #3421      +/-   ##
============================================
- Coverage     69.96%   68.19%   -1.78%     
- Complexity     1599     1642      +43     
============================================
  Files           319      323       +4     
  Lines          8587     9001     +414     
  Branches        945     1008      +63     
============================================
+ Hits           6008     6138     +130     
- Misses         2005     2270     +265     
- Partials        574      593      +19     

Files with missing lines	Coverage Δ
...droid/data/remote/firebase/schema/TaskConverter.kt	84.78% <100.00%> (+3.38%)	⬆️
.../groundplatform/android/model/task/DrawGeometry.kt	100.00% <100.00%> (ø)
...java/org/groundplatform/android/model/task/Task.kt	100.00% <100.00%> (ø)
...tform/android/model/submission/GeometryTaskData.kt	88.88% <66.66%> (-11.12%)	⬇️
...droid/ui/datacollection/DataCollectionViewModel.kt	78.67% <0.00%> (-0.38%)	⬇️
...id/data/local/room/converter/ValueJsonConverter.kt	61.29% <33.33%> (-2.87%)	⬇️
...tion/tasks/geometry/DrawGeometryTaskMapFragment.kt	0.00% <0.00%> (ø)
...ection/tasks/geometry/DrawGeometryTaskViewModel.kt	50.89% <50.89%> (ø)
...lection/tasks/geometry/DrawGeometryTaskFragment.kt	0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[shobhitagarwal1612]

Please attach a screen recording as well to the description.

[shobhitagarwal1612]

This seems error prone to me. I'd prefer if the entire object was encapsulated in DrawGeometryTaskData which can then internally have a location or geometry type data.

[shobhitagarwal1612]

Can we reuse the logic for drawing polygon using DrawAreaTaskViewModel?

[shobhitagarwal1612]

Let's not remove the existing tests for DRAW_AREA and DRO_PIN task types as we'll continue supporting these types for legacy surveys. Instead, let's add tests for the new task type.

[shobhitagarwal1612]

Can you please attach a screencast with require_device_location set to true for both DROP_PIN and DRAW_AREA?