Skip to content

Added DrawGeometryTask #3421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
anandwana001 wants to merge 9 commits into
base: master
Choose a base branch
from

Merge branch 'master' into anandwana001/3148/drawgeometrytask

724d17b
Select commit
Loading
Failed to load commit list.
Open

Added DrawGeometryTask #3421

Merge branch 'master' into anandwana001/3148/drawgeometrytask
724d17b
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Dec 28, 2025 in 0s

68.19% (-1.78%) compared to 68dce1c

View this Pull Request on Codecov

68.19% (-1.78%) compared to 68dce1c

Details

Codecov Report

❌ Patch coverage is 31.50358% with 287 lines in your changes missing coverage. Please review.
✅ Project coverage is 68.19%. Comparing base (68dce1c) to head (724d17b).

Files with missing lines Patch % Lines
...lection/tasks/geometry/DrawGeometryTaskFragment.kt 0.00% 117 Missing ⚠️
...ection/tasks/geometry/DrawGeometryTaskViewModel.kt 50.89% 93 Missing and 17 partials ⚠️
...tion/tasks/geometry/DrawGeometryTaskMapFragment.kt 0.00% 52 Missing ⚠️
...id/data/local/room/converter/ValueJsonConverter.kt 33.33% 2 Missing and 4 partials ⚠️
...tform/android/model/submission/GeometryTaskData.kt 66.66% 1 Missing ⚠️
...droid/ui/datacollection/DataCollectionViewModel.kt 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##             master    #3421      +/-   ##
============================================
- Coverage     69.96%   68.19%   -1.78%     
- Complexity     1599     1642      +43     
============================================
  Files           319      323       +4     
  Lines          8587     9001     +414     
  Branches        945     1008      +63     
============================================
+ Hits           6008     6138     +130     
- Misses         2005     2270     +265     
- Partials        574      593      +19
Files with missing lines Coverage Δ
...droid/data/remote/firebase/schema/TaskConverter.kt 84.78% <100.00%> (+3.38%) ⬆️
.../groundplatform/android/model/task/DrawGeometry.kt 100.00% <100.00%> (ø)
...java/org/groundplatform/android/model/task/Task.kt 100.00% <100.00%> (ø)
...tform/android/model/submission/GeometryTaskData.kt 88.88% <66.66%> (-11.12%) ⬇️
...droid/ui/datacollection/DataCollectionViewModel.kt 78.67% <0.00%> (-0.38%) ⬇️
...id/data/local/room/converter/ValueJsonConverter.kt 61.29% <33.33%> (-2.87%) ⬇️
...tion/tasks/geometry/DrawGeometryTaskMapFragment.kt 0.00% <0.00%> (ø)
...ection/tasks/geometry/DrawGeometryTaskViewModel.kt 50.89% <50.89%> (ø)
...lection/tasks/geometry/DrawGeometryTaskFragment.kt 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
View more details on Codecov