-
Notifications
You must be signed in to change notification settings - Fork 137
Added DrawGeometryTask #3421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
anandwana001
wants to merge
9
commits into
master
Choose a base branch
from
anandwana001/3148/drawgeometrytask
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Added DrawGeometryTask #3421
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
8c37721
added drawGeometryTrask
anandwana001 2e29442
Merge branch 'master' into anandwana001/3148/drawgeometrytask
anandwana001 4faba0d
added the missing DRAW_GEOMETRY
anandwana001 5a51b3e
Merge branch 'master' into anandwana001/3148/drawgeometrytask
anandwana001 626bcc8
test fix
anandwana001 8580206
Merge remote-tracking branch 'origin/anandwana001/3148/drawgeometryta…
anandwana001 e1f8168
Merge branch 'master' into anandwana001/3148/drawgeometrytask
anandwana001 7f610d3
suggested fixes
anandwana001 724d17b
Merge branch 'master' into anandwana001/3148/drawgeometrytask
anandwana001 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
32 changes: 32 additions & 0 deletions
32
app/src/main/java/org/groundplatform/android/model/task/DrawGeometry.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,32 @@ | ||
| /* | ||
| * Copyright 2025 Google LLC | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * https://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| package org.groundplatform.android.model.task | ||
|
|
||
| /** | ||
| * Suggested configuration for a task that involves drawing geometry on a map. | ||
| * | ||
| * @property isLocationLockRequired whether the user's location must be locked to the map viewport | ||
| * before they can start drawing. | ||
| * @property minAccuracyMeters the minimum accuracy (in meters) required for the user's location to | ||
| * be considered valid for drawing. | ||
| * @property allowedMethods the list of allowed methods for drawing geometry (e.g. "DROP_PIN", | ||
| * "DRAW_AREA"). | ||
| */ | ||
| data class DrawGeometry( | ||
| val isLocationLockRequired: Boolean, | ||
| val minAccuracyMeters: Float, | ||
| val allowedMethods: List<String>, | ||
anandwana001 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| ) | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems error prone to me. I'd prefer if the entire object was encapsulated in
DrawGeometryTaskDatawhich can then internally have a location or geometry type data.