Skip to content

fix: use retained research in session questions and follow-ups - #671

Merged
magnus919 merged 25 commits into
mainfrom
codex/workspace-live-evidence
Oct 16, 2026
Merged

magnus919 merged 25 commits into
mainfrom
codex/workspace-live-evidence

Conversation

@magnus919

@magnus919 magnus919 commented Oct 16, 2026 •

Copy link
Copy Markdown
Contributor

Attached research can now supply evidence when a user asks a session question. The session resolves the saved source text when it is used, checks that it has not changed, and refuses references whose research has been deleted or expired.

The API, CLI and MCP also gain explicit follow-up execution. Previewing a follow-up does no research. Executing it validates the selected evidence and starts a separate run with a stable retry key.

The public scrape test exposed a related gap: a normal request could accept challenge text before trying browser recovery. The shared scraper now escalates those pages. A verified browser solve can clear a narrow false alarm caused by a page mentioning CAPTCHA; unresolved widgets and other challenge markers remain errors and are not cached.

Validation:

  • 4,707 workspace unit/service tests and 42 subtests passed, with 21 skips; agent type checks passed.
  • Isolated Valkey tests cover attachment ownership, revision checks and fresh-connection reads.
  • A document test uses real Parse/API HTTP servers and Valkey, with CLI subprocesses and MCP tools. It checks upload, questions, exact citations, deletion, foreign-owner rejection and a relevant passage beyond character 8,000.
  • The capture correction passed 168 focused tests and type checks across 53 scraper files. Its unchanged public API container probe passed in runtime CI, including normal-request recovery and unresolved-challenge refusal without caching.

Model responses in these tests are controlled. This proves integration and evidence handling, not live answer quality. Final PostgreSQL and container checks remain pending.

Depends on #670 and contributes to the 1.0.1 cleanup; it does not complete the release checklist by itself.

@factory-droid

factory-droid Bot commented Oct 16, 2026 •

Copy link
Copy Markdown
Contributor

Droid encountered an error —— View job

Droid Exec exceeded the maximum of 100 turns and was stopped. This usually means the agent got stuck in a loop.

Security Review

@magnus919
magnus919 changed the base branch from codex/live-durable-research to main October 16, 2026 03:14
Signed-off-by: magnus919 <magnus919@users.noreply.github.com>
Signed-off-by: magnus919 <magnus919@users.noreply.github.com>
Signed-off-by: magnus919 <magnus919@users.noreply.github.com>
Signed-off-by: magnus919 <magnus919@users.noreply.github.com>
…rkspace-live-evidence

Signed-off-by: magnus919 <magnus919@users.noreply.github.com>
Signed-off-by: magnus919 <magnus919@users.noreply.github.com>
Signed-off-by: magnus919 <magnus919@users.noreply.github.com>
@magnus919
magnus919 merged commit 7baf683 into main Oct 16, 2026
24 checks passed
@magnus919
magnus919 deleted the codex/workspace-live-evidence branch October 16, 2026 06:16
@magnus919
magnus919 restored the codex/workspace-live-evidence branch October 16, 2026 08:28
@magnus919
magnus919 deleted the codex/workspace-live-evidence branch October 16, 2026 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant