Conversation
Domica
changed the title
Domica
force-pushed
the
feat-export-original-resolution
branch
from
September 22, 2026 12:03
40a5a7e to
2f1767a
Compare
…tiers The Resolution dropdown only offered 16:9 short sides, which are wrong for a 1:1 or vertical project. Adds three options beside the four named tiers: - Original: the project's own frame, no scaling. A 1:1 project exports 1:1, a 9:16 project exports 9:16. - 1.5x: 1.5 times the project frame. 300 x 300 -> 450 x 450. - 2x: twice the project frame. 300 x 300 -> 600 x 600. The named tiers already scaled along the project aspect in code; this is mostly making the labels honest for the shapes those tiers do not fit. Closes jub0t#109.
"1.5x" and "2x" alone do not say what is being scaled. The dropdown offers resolution tiers beside the project options, so a reader could take them for a scaling of the tier. They scale the project frame, and the label now says so.
The named tiers scale along the project aspect — correct for a project that shares the shape, but a 21:9 widescreen delivery wanted a fixed frame. 2560 × 1080 is now a named option, and Original/1.5×/2× shift one index down.
The merge of the resolution options into concat_fixed dropped the colour range row that the colour work added: app.slint still forwarded color-range-changed, but ExportDialog no longer had the callback, so the build script failed on app.slint. Brings the ExportData field, the callback, the Colour section and the Rust side (ExportMsg::ColorRangeChanged, ExportPane.color_range, color_range() and the spec field) back, with the resolution options untouched.
"2560 × 1080" alone did not say the frame is ultrawide. The label now reads "Wide 21:9 · 2560 × 1080", the shape first, the pixels after, matching how the named tiers read elsewhere.
The rebase onto main kept both the helper this branch added and the one main had merged from the colour work. They are identical; the main version stays.
Domica
force-pushed
the
feat-export-original-resolution
branch
from
September 22, 2026 19:19
58c12aa to
04a49c9
Compare
This was referenced Sep 22, 2026
Contributor
Author
|
Withdrawn. Will be opened at a later date. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The Resolution dropdown offered four 16:9 short sides (4K, QHD, 1080p, 720p) as the only choices, whatever the project's own aspect was, and the Frame rate dropdown offered 24/30/60 only. A 1:1 or vertical project, or a project whose rate is 25 or 29.97, had no way to export at the project's own numbers through the sheet — the named tiers scaled along the project aspect in code but the labels disagreed, and the rate offered nothing but the three the dropdown carried.
Fix
Three options beside the four named resolution tiers:
scaling. A 1:1 project exports 1:1, a 9:16 project exports 9:16.
And one beside the three named rates:
The named tiers keep their meaning; they already scaled along the project's aspect in code, so this is mostly making the labels honest.
Companion
The project side of the same issue is the companion PR — the Format picker on the launch screen that lets a project be born 9:16, 4:5 or 1:1 in the first place. This PR is the export half.
Verification
cargo check -p concat(runs on CI)at the resolution the dropdown names, and
ffprobeagreesCloses #109.