Skip to content

Move Chutoro orchestration into mod.rs - #294

Open
leynos wants to merge 1 commit into
harden-markdown-formatter-scopefrom
harden-lint-modules
Open

leynos wants to merge 1 commit into
harden-markdown-formatter-scopefrom
harden-lint-modules

Conversation

@leynos

@leynos leynos commented Sep 24, 2026 •

Copy link
Copy Markdown
Owner

Summary

This branch moves the Chutoro orchestration module into chutoro/mod.rs so its source sits beside its child module ahead of self_named_module_files enforcement. The source is unchanged apart from the two paths that load its existing test files.

This is the structural layer after formatter scope PR #293. The bench-target layout and remaining integration-test file splits follow in separate layers.

Review walkthrough

Validation

  • git diff --find-renames=80%: 99% rename; reversing the two path changes reproduces the original file hash.
  • Sequential local gates passed: make check-fmt, pinned spelling and Markdown gates, make nixie, mbake validate Makefile, make test-workflow-contracts (446 passed), make typecheck, and make lint (Rustdoc, Clippy and Whitaker).
  • make test: 1,242 passed; 3 tests skipped and 8 binaries excluded by repository configuration. The no-default-features core library test passed 34 cases; stable doctests passed 82 cases with the documented ignored cases.
  • make verus: 25 proofs verified. make kani: all six practical harness invocations reported successful verification.
  • The moved module remains 366 lines. The generated spelling configuration matched the pinned base and generated hashes.

Notes

  • Cargo still reports the pre-existing duplicate-target warnings for the two HNSW benchmark files. A separate bench-layout layer owns those paths; this branch does not change benchmark registration.
  • The two oversized integration-test files are reserved for a separate structural layer. No runtime logic or public API changes here.
  • Hosted build-test and verus-proofs passed on this head. The inner CodeScene changed-line coverage upload and check were skipped because the stacked base is not an analysed default branch; the green outer job is not a coverage verdict.

Summary by Sourcery

Enhancements:

  • Relocate the Chutoro orchestration module into chutoro/mod.rs while preserving its behavior and public API.

References

@coderabbitai

coderabbitai Bot commented Sep 24, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

  • ▶️ Resume reviews
  • 🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Team

Run ID: 4426197d-3bad-4cf3-bfce-0a7e3ccd20b0

📥 Commits

Reviewing files that changed from the base of the PR and between 132ddac and 2f31f6a.

📒 Files selected for processing (1)
  • chutoro-core/src/chutoro/mod.rs
🔗 Linked repositories identified

CodeRabbit considers these linked repositories for cross-repo context during reviews:

  • leynos/whitaker (auto-detected) → reviewed against open PR #364 harden-lint-modules instead of the default branch
  • leynos/typos-config-builder (auto-detected)
  • leynos/shared-actions (auto-detected)
  • leynos/mdtablefix (auto-detected) → reviewed against open PR #539 harden-lint-modules instead of the default branch
  • leynos/df12-www (auto-detected)

Included review availability: 3 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 4 reviews per hour.


Summary

  • Move Chutoro’s orchestration module into chutoro/mod.rs, beside its properties submodule.
  • Update the test-module paths to load the existing chutoro_tests.rs and properties.rs files.
  • Keep exported and public declarations unchanged.

Validation

Test and verification results are not available in the supplied change summary.

Walkthrough

The test module path now resolves from the parent directory. The CPU-only properties module path now resolves relative to the current module file.

Changes

Module Path Resolution

Layer / File(s) Summary
Update module paths
chutoro-core/src/chutoro/mod.rs
The test module path changes to ../chutoro_tests.rs. The CPU-only properties module path changes to properties.rs.

Priority: ⬇️ Low

Change: Refactor

Merge Risk: ⚪ Minimal · up to 2f31f

No actionable merge-blocking risk remains.

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly describes the main change: moving Chutoro orchestration into mod.rs. No roadmap or issue number is required because none is referenced for this change.
Description check ✅ Passed The description directly explains the module relocation, path updates, scope, validation, and preserved behaviour. It is relevant to the changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Testing (Overall) ✅ Passed Pass. The pull request only renames chutoro.rs to chutoro/mod.rs and changes two relative #[path] attributes. The path-normalised source is identical to the base revision, with no new functional…
User-Facing Documentation ✅ Passed Pass the documentation check. Treat this as a structural module relocation, not new or changed user-facing functionality. The authoritative diff contains only a 99% rename and two test-file path updat…
Developer Documentation ✅ Passed PASS — The pull request only renames chutoro-core/src/chutoro.rs to chutoro-core/src/chutoro/mod.rs and changes two relative test paths. The destination content matches the source with only those …
Module-Level Documentation ✅ Passed The moved chutoro-core/src/chutoro/mod.rs has module-level documentation at lines 1–4. It states the module purpose as core Chutoro clustering orchestration, identifies its runtime entry point, and …
Testing (Unit And Behavioural) ✅ Passed Pass this check. The pull request only renames chutoro.rs to chutoro/mod.rs and updates two test-file paths. The orchestration source and existing test files are unchanged. Existing tests cover ba…
Testing (Property / Proof) ✅ Passed Pass this check. The pull request only renames chutoro-core/src/chutoro.rs to chutoro-core/src/chutoro/mod.rs and updates two #[path] attributes. After normalising those paths, the module conten…
Testing (Compile-Time / Ui) ✅ Passed Pass this check. The review-scoped diff is a 99% rename from chutoro-core/src/chutoro.rs to chutoro-core/src/chutoro/mod.rs, with only two internal #[path] updates. It changes no public declarat…
Unit Architecture ✅ Passed Pass. The PR only relocates chutoro.rs to chutoro/mod.rs and updates two test-module paths. Normalising those path changes makes the base and head module contents identical. The lib.rs declarati…
Domain Architecture ✅ Passed Pass the Domain Architecture check. The pull request only relocates chutoro.rs to chutoro/mod.rs and updates two relative test paths. The module content is otherwise identical, and no domain, adap…
Observability ✅ Passed Mark this check as PASS. The pull request only renames chutoro-core/src/chutoro.rs to chutoro-core/src/chutoro/mod.rs and changes two #[path] values for test modules. It does not alter productio…

Point tests to their parent place,
Resolve properties near their base.
Keep each module path clear,
Let both declarations steer,
And compile with paths in place.

Comment @coderabbitai help to get the list of available commands.

@sourcery-ai

sourcery-ai Bot commented Sep 24, 2026

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR is a structural module-file migration: the unchanged Chutoro orchestration code now lives in chutoro/mod.rs beside its child module, with only the two feature-gated test paths updated for the new location. Reviewers should verify the rename and path resolution; no runtime logic, API, benchmark layout, or integration-test structure changes are intended.

File-Level Changes

Change Details Files
Relocate the Chutoro orchestration implementation into the directory module without changing its runtime behavior or public API.
  • Move the 366-line orchestration source from the flat module file to the directory module file.
  • Preserve the existing test module while adjusting its relative path to the parent directory.
  • Preserve the CPU-gated property tests while adjusting their path relative to the new module location.
chutoro-core/src/chutoro.rs
chutoro-core/src/chutoro/mod.rs

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

codescene-access[bot]

This comment was marked as outdated.

@leynos
leynos marked this pull request as ready for review September 24, 2026 05:29

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry @leynos, you've used your own review budget of 250,000 diff characters for the last 7 days.

You can request another review in 5 hours and 17 minutes by commenting @sourcery-ai review. Upgrade to get a review now.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 24, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-24T05:31:43.447714Z 4dfceba Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@leynos
leynos added this pull request to stack #297 September 24, 2026 14:08
Keep the Chutoro module beside its properties submodule ahead of
self-named-module lint enforcement. Adjust the test module paths so
both test configurations continue to use their existing source files.
@leynos
leynos force-pushed the harden-lint-modules branch from 4dfceba to 2f31f6a Compare September 24, 2026 14:37
@wafflecat-df12

Copy link
Copy Markdown
Collaborator

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Sep 25, 2026 •

Copy link
Copy Markdown
Contributor
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants