Skip to content

Update dark mode theme settings - #3

Merged
sabraman merged 1 commit into
mainfrom
dark-mode-013
May 16, 2026
Merged

Update dark mode theme settings#3
sabraman merged 1 commit into
mainfrom
dark-mode-013

Conversation

@sabraman

@sabraman sabraman commented May 16, 2026

Copy link
Copy Markdown
Contributor

Summary\n- bump dark mode package to 0.1.3\n- add package-owned Antialiasing toggle, defaulting off\n- request half refresh and package-setting antialiasing from the theme descriptor\n\n## Validation\n- python3 ../marginalia-sdk/tools/validate_manifest.py --profile publish */manifest.json\n- rebuilt all example .mpkg.zip archives

Summary by CodeRabbit

  • New Features

    • Added Antialiasing setting (disabled by default) to prevent grayscale overlay issues on e-ink displays
    • Enabled half refresh mode to reduce ghosting effects from polarity inversion
  • Documentation

    • Updated release notes to reflect new display settings and version information

Review Change Stack

@coderabbitai

coderabbitai Bot commented May 16, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 4082a4d6-a9e6-43d5-9c5d-19c5cf9a715c

📥 Commits

Reviewing files that changed from the base of the PR and between 96f76fa and 0eb42e5.

📒 Files selected for processing (4)
  • README.md
  • dark-mode-theme/README.md
  • dark-mode-theme/manifest.json
  • dark-mode-theme/src/theme.json

📝 Walkthrough

Walkthrough

This PR releases dark-mode theme v0.1.3 with display refinements. The manifest version bumps to 0.1.3 and adds a new textAntialiasing boolean setting. The theme configuration applies half-refresh mode and delegates antialiasing control. Documentation describes the new behaviors and release references update to v0.1.3 across all files.

Changes

Dark Mode Theme v0.1.3 Release

Layer / File(s) Summary
Manifest version and textAntialiasing setting definition
dark-mode-theme/manifest.json
Manifest version incremented from 0.1.2 to 0.1.3; new boolean textAntialiasing setting (label "Antialiasing", default false) added to expose antialiasing control in theme settings.
Theme runtime configuration with refresh and antialiasing
dark-mode-theme/src/theme.json
Theme now sets refreshMode to half (to reduce e-ink ghosting during polarity inversion) and textAntialiasing to package-setting (delegating control to the manifest setting).
Documentation and release archive updates
dark-mode-theme/README.md, README.md
Theme README adds bullets describing half-refresh behavior during activation and the new Antialiasing setting (default off); version references and release archive links updated from v0.1.2 to v0.1.3 in both theme and root READMEs.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

  • marginalia-os/marginalia-examples#2: Both PRs modify dark-mode-theme/manifest.json and dark-mode-theme/README.md to add theme settings and bump the release version; this PR adds textAntialiasing and refreshMode, while the earlier PR added invertScreen.

Poem

🐰 A theme so dark, now half-refreshed and bright,
With antialiasing set right, by default off in sight,
Version bumped from point-two to point-three,
The e-ink ghosts are banished with glee,
All docs and archives in sync, as they should be!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: updating dark mode theme settings, including version bump, antialiasing toggle, and refresh mode configuration.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch dark-mode-013

Comment @coderabbitai help to get the list of available commands and usage tips.

@blacksmith-sh

blacksmith-sh Bot commented May 16, 2026

Copy link
Copy Markdown

Blacksmith Account Suspended

This Blacksmith account requires additional verification. Jobs targeting Blacksmith runners will not be picked up and will remain queued until they timeout.

Please contact Blacksmith Support for assistance.

@sabraman
sabraman merged commit eb4528b into main May 16, 2026
2 checks passed
@sabraman
sabraman deleted the dark-mode-013 branch May 16, 2026 01:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant