Skip to content

fix: soften dark mode refresh cadence - #4

Merged
sabraman merged 1 commit into
mainfrom
fix/dark-mode-refresh-cadence
May 16, 2026
Merged

fix: soften dark mode refresh cadence#4
sabraman merged 1 commit into
mainfrom
fix/dark-mode-refresh-cadence

Conversation

@sabraman

@sabraman sabraman commented May 16, 2026

Copy link
Copy Markdown
Contributor

Summary

  • release Dark Mode 0.1.4
  • remove the half-refresh request from the theme descriptor
  • keep the package-owned antialiasing setting and docs updated

Validation

  • python3 ../marginalia-sdk/tools/validate_manifest.py --profile publish */manifest.json
  • built .mpkg.zip archives with ../marginalia-sdk/tools/build_package.py
  • /Users/sabraman/.local/bin/coderabbit review --agent --base main

Summary by CodeRabbit

  • Documentation

    • Updated README files with version 0.1.4 release information and screen refresh behavior details.
  • Chores

    • Bumped package version to 0.1.4.
    • Updated theme configuration settings.

Review Change Stack

@coderabbitai

coderabbitai Bot commented May 16, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 7f726ff8-ce82-4762-bae9-3250c785bbe9

📥 Commits

Reviewing files that changed from the base of the PR and between eb4528b and a1f5127.

📒 Files selected for processing (4)
  • README.md
  • dark-mode-theme/README.md
  • dark-mode-theme/manifest.json
  • dark-mode-theme/src/theme.json
💤 Files with no reviewable changes (1)
  • dark-mode-theme/src/theme.json

📝 Walkthrough

Walkthrough

The dark-mode-theme package is released as v0.1.4. The theme configuration removes the refreshMode: "half" setting to use the firmware's normal refresh cadence instead of half-refresh. Documentation is updated to reflect this behavior change, package version is bumped to 0.1.4, and published archive links are updated across the README files to reference the new release.

Changes

Dark Mode Theme v0.1.4 Release

Layer / File(s) Summary
Theme refresh behavior configuration
dark-mode-theme/src/theme.json, dark-mode-theme/README.md
The refreshMode: "half" property is removed from the theme configuration. Documentation is updated to state the theme now uses the firmware's normal refresh cadence to avoid harsh X3 half-refresh flashes, replacing the prior half-refresh strategy for reducing ghosting.
Version and published archives
dark-mode-theme/manifest.json, dark-mode-theme/README.md, README.md
Version incremented to 0.1.4 in the manifest. Archive download URLs across the dark-mode package README and root README are updated to reference the v0.1.4 release asset instead of v0.1.3.

Possibly related PRs

  • marginalia-os/marginalia-examples#3: Prior PR that added refreshMode: "half" and textAntialiasing settings to the dark-mode theme; this PR removes the refreshMode field as part of the v0.1.4 release.
  • marginalia-os/marginalia-examples#2: Earlier version bump that also updated dark-mode-theme manifest and archive links; this PR continues the versioning pattern with additional theme configuration changes.

Poem

🐰 A theme refreshes, half-flashes fade,
Version bumps and archives remade,
Normal cadence now takes the stage,
Dark mode 0.1.4 turns the page! 🌙

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'fix: soften dark mode refresh cadence' accurately describes the main change: removing the half-refresh request to use the firmware's normal refresh cadence, which softens visual artifacts.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/dark-mode-refresh-cadence

Comment @coderabbitai help to get the list of available commands and usage tips.

@sabraman
sabraman merged commit 505ab2a into main May 16, 2026
2 checks passed
@sabraman
sabraman deleted the fix/dark-mode-refresh-cadence branch May 16, 2026 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant