Skip to content

ci: remove the ci-status mirror job now that CI Status is required - #178

Merged
kyle-sexton merged 1 commit into
mainfrom
ci/remove-ci-status-mirror
Nov 13, 2026
Merged

kyle-sexton merged 1 commit into
mainfrom
ci/remove-ci-status-mirror

Conversation

@kyle-sexton

Copy link
Copy Markdown
Member

No related issue: step C of the owner-approved ci-status to CI Status required-check rename (owner decision "go w/ recommendations": remove the mirror jobs after a day of merges under the new requirement).

Summary

The org ci-gate ruleset has required CI Status since 2026-11-12T17:07Z. This removes the report-ci-status mirror job, which repeated the gate's conclusion under the old check name ci-status, and the alias-jobs: ci-status input that made the aggregate ignore it.

Fix

  • .github/workflows/pr-require-checks.yml: the report-ci-status job and the alias-jobs: ci-status input with its comment are removed. The job key ci-status is unchanged (other comments and needs: name it).
  • .github/workflows/pr-automerge-dependabot.yml: the header comment names CI Status as the required check auto-merge waits on.
  • docs/conventions/source-control.yaml: the pr-contract comment says it runs inside CI Status, the single required check.

Verification

  • actionlint on both edited workflows: no findings (this repository has no .github/actionlint.yaml).
  • alias-jobs is optional in the pinned aggregate-results (ac4d878): default: ''.
  • No test or script in this repository references report-ci-status, alias-jobs or the job list (git grep).
  • No plugin component changed, so the documentation preflight in AGENTS.md does not apply.

Related

Follow-ups

These are managed by the standards sync and were left unedited; they need a melodic-software/standards change:

  • Pre-existing (advisory): .claude/rules/pr-body-contract.md:3 says "inside ci-status"; it should name CI Status.
  • Pre-existing (advisory): REVIEW.md:89,91 name ci-status as the check a Dependabot pull request merges on.
  • Pre-existing (advisory): docs/standards/issue-tracker.md:30,101 name ci-status as the required check.
  • Pre-existing (advisory): .github/workflows/pr-check-managed-files-hosted.yml:21 names ci-status.

🤖 Generated with Claude Code

https://claude.ai/code/session_01RMa43ySvw2yzRFMu7Kekcu

The org ci-gate ruleset has required `CI Status` since
2026-11-12T17:07Z. Remove the `report-ci-status` job, which repeated the
gate's conclusion under the old check name `ci-status`, and the
`alias-jobs: ci-status` input with its comment. The Dependabot automerge
comment and the source-control convention now name `CI Status` as the
required check.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01RMa43ySvw2yzRFMu7Kekcu
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 13, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-13T20:33:54.024714Z 5c8a189 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions

Copy link
Copy Markdown

claude-security-review reviewed 5c8a1890e90d5f12d52c212ba898299f9a954090: 0 finding(s), 0 as inline comments.

No security issues found in this pull request.

The diff removes the report-ci-status mirror job and the alias-jobs: ci-status input in .github/workflows/pr-require-checks.yml. It also updates the check name in two comments and one YAML comment.

  • Mirror job removal: The job was a permissions: {} job that only echoed and asserted needs.ci-status.result. It held no token and no secrets, and nothing consumed its output. Removing it grants nothing.
  • alias-jobs removal: The input only told the aggregator to ignore the mirror job when reading the run shape. No job named ci-status exists at head any more; the remaining job is CI Status (pr-require-checks.yml:108-109). The aggregate step's other inputs and its treat-skipped-as: fail are unchanged, and the pinned action SHA is unchanged.
  • Merge gate: Nothing here weakens it. If a branch ruleset still required the old ci-status context, the gate would stay unsatisfied, which fails closed. That ruleset is outside the diff. The commit message says CI Status is now the required check.
  • Trust controls and manifests: The diff touches no trusted-actor list, token request, kill switch or token broker. It touches no merge-hold script, no CODEOWNERS or .gitmodules, and no plugin or marketplace manifest. The pr-require-checks.yml hold-step rule did not apply: the diff changes no hold step, and the removed job was an echo-only mirror, not a hold.
  • Instruction surface: docs/conventions/source-control.yaml is a comment-only change that renames the check. It removes no standing instruction.

manifest: not hit.
critical-findings: 0

@github-actions

Copy link
Copy Markdown

claude-review reviewed 5c8a1890e90d5f12d52c212ba898299f9a954090: 0 finding(s), 0 as inline comments.

No findings.

The change removes the report-ci-status mirror job and the alias-jobs: ci-status input from .github/workflows/pr-require-checks.yml. It also updates two comments to name CI Status.

  • Job key and name: the job key ci-status (display name CI Status) is unchanged, so the required check keeps its name. I read the head file and confirmed this.
  • Leftover references: I grepped .github, docs, scripts and tests for report-ci-status and alias-jobs. Nothing is left that depends on the removed job or input.
  • Aggregation: the aggregate step takes needs.*.result from the real lanes only, so dropping the mirror job, which depended on ci-status, does not change its inputs.
  • Closing issue: the PR states "No related issue" with a reason, so there are no acceptance criteria to check.
  • Path-scoped rules: .claude/rules/pr-body-contract.md has no paths: frontmatter and no changed file matches it.
  • Manifests: no plugin manifest changed, so no manifest <field> lines apply.
  • PR contract: the body follows the contract: "No related issue" line, then ## Summary, ## Fix, ## Verification and ## Related.

I did not run actionlint; the actionlint result and the claim that alias-jobs defaults to '' in the pinned aggregate action are the author's and unverified by me.

Pre-existing (advisory): .claude/rules/pr-body-contract.md:3 and the other standards-synced files the PR lists still say ci-status. The author already named these as follow-ups that belong in melodic-software/standards.

Verifier dropped 0 of 0 candidates.

@kyle-sexton
kyle-sexton merged commit 3e1027f into main Nov 13, 2026
8 checks passed
@kyle-sexton
kyle-sexton deleted the ci/remove-ci-status-mirror branch November 13, 2026 20:38
kyle-sexton added a commit to melodic-software/cursor-plugins that referenced this pull request Nov 13, 2026
)

No related issue: step C of the owner-approved `ci-status` to `CI
Status` required-check rename (owner decision "go w/ recommendations":
remove the mirror jobs after a day of merges under the new requirement).

## Summary

The org ci-gate ruleset has required `CI Status` since
2026-11-12T17:07Z. This removes the `report-ci-status` mirror job, which
repeated the gate's conclusion under the old check name `ci-status`, and
the `alias-jobs: ci-status` input that made the aggregate ignore it.
Present-tense docs and comments now name `CI Status` as the required
check.

## Fix

- `.github/workflows/pr-require-checks.yml`: the `report-ci-status` job
and the `alias-jobs: ci-status` input with its comment are removed; the
comment above the gate job names `CI Status` as the context the ruleset
requires (it said `ci-status` was one of four). The job key `ci-status`
is unchanged.
- `AGENTS.md` ("Pull requests"), `.github/dependabot.yml` and
`.github/workflows/pr-automerge-dependabot.yml`: comments and prose name
`CI Status`.

## Verification

- `actionlint` on both edited workflows: no findings (this repository
has no `.github/actionlint.yaml`).
- `alias-jobs` is optional in the pinned `aggregate-results` (ac4d878):
`default: ''`.
- No test or script in this repository references `report-ci-status`,
`alias-jobs` or the job list (`git grep`).

## Related

- Same change in claude-code-plugins:
melodic-software/claude-code-plugins#16005, and in
melodic-software/codex-plugins#178.

## Follow-ups

These are managed by the standards sync and were left unedited; they
need a melodic-software/standards change:

- Pre-existing (advisory): `REVIEW.md:89,91` name `ci-status` as the
check a Dependabot pull request merges on.
- Pre-existing (advisory):
`.github/workflows/pr-check-managed-files-hosted.yml:21` names
`ci-status` as the aggregate.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

https://claude.ai/code/session_01RMa43ySvw2yzRFMu7Kekcu

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
kyle-sexton added a commit to melodic-software/ci-runner that referenced this pull request Nov 13, 2026
)

No related issue: step C of the owner-approved `ci-status` to `CI
Status` required-check rename (owner decision "go w/ recommendations":
remove the mirror jobs after a day of merges under the new requirement).

## Summary

The org ci-gate ruleset has required `CI Status` since
2026-11-12T17:07Z. This removes the `report-ci-status` mirror job, which
repeated the gate's conclusion under the old check name `ci-status`, the
`alias-jobs: ci-status` input that made the aggregate ignore it, and the
test that pinned the mirror. Present-tense docs and comments now name
`CI Status` as the required check.

## Fix

- `.github/workflows/pr-require-checks.yml`: the `report-ci-status` job
and the `alias-jobs: ci-status` input with its comment are removed. The
job key `ci-status` is unchanged, and no workflow pin changed.
- `.github/scripts/workflow-pin-metadata.test.cjs`: the
"report-ci-status mirrors the gateway under its old check name" test is
removed with the job it pinned; the `ci-status` gateway test is
unchanged.
- `docs/conventions/source-control.yaml`, `docs/releases.md` and
`.github/workflows/pr-automerge-dependabot.yml`: name `CI Status` as the
required check.
- Left alone: `docs/adr/` and `release/dependency-drift-review.json`
(dated records).

## Verification

- `node --test .github/scripts/workflow-pin-metadata.test.cjs`: 5 tests,
5 pass.
- `actionlint` on both edited workflows with the repository's
`.github/actionlint.yaml`: no findings.
- `alias-jobs` is optional in the pinned `aggregate-results` (9bfbca8,
v0.73.0): `default: ''`.

## Related

- Same change in claude-code-plugins:
melodic-software/claude-code-plugins#16005, and in
melodic-software/codex-plugins#178, melodic-software/cursor-plugins#150
and melodic-software/songwriting#56.

## Follow-ups

These are managed by the standards sync and were left unedited; they
need a melodic-software/standards change:

- Pre-existing (advisory): `.claude/rules/pr-body-contract.md:3` says
"inside `ci-status`"; it should name `CI Status`.
- Pre-existing (advisory): `REVIEW.md:89,91` name `ci-status` as the
check a Dependabot pull request merges on.
- Pre-existing (advisory): `docs/standards/issue-tracker.md:30,101` name
`ci-status` as the required check.
- Pre-existing (advisory):
`.github/workflows/pr-check-managed-files-hosted.yml:21` names
`ci-status` as the aggregate.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

https://claude.ai/code/session_01RMa43ySvw2yzRFMu7Kekcu

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant