Skip to content

chore: add ecosystem records mirroring CI's test and link checks - #183

Merged
kyle-sexton merged 3 commits into
mainfrom
chore/ecosystem-records
Nov 14, 2026
Merged

kyle-sexton merged 3 commits into
mainfrom
chore/ecosystem-records

Conversation

@kyle-sexton

Copy link
Copy Markdown
Member

Closes melodic-software/claude-code-plugins#15727

Summary

Adds .claude/ecosystems/ records (bash, cross-cutting, markdown, python, typescript, yaml), so /toolchain:check and /toolchain:lint run what this repository's CI runs and no bundled default runs a tool CI does not.

Fix

This repository's CI runs three things: npm test, npm run validate and the offline link check (pr-require-checks.yml:73-153). The records mirror that, each citing its CI step by file:line and naming the pinned ci-workflows commit for cross-repository cites.

  • typescript.yaml: test-cmd is npm test && npm run validate, as CI's two steps, which stop at the first failure. No install: package.json declares no dependencies. The node pin follows .node-version, a standards-synced file.
  • cross-cutting.yaml: check-cmd is lychee offline over **/*.md with lychee.toml, with CI's pinned version and checksum. Typos, gitleaks and editorconfig-checker are not run in CI here and get no command.
  • bash.yaml, markdown.yaml, python.yaml, yaml.yaml: enabled with every command null. The repository holds files of each type and CI checks none of them with a linter; null commands stop the bundled defaults (shellcheck and shfmt, markdownlint, the Python lint, actionlint) from running.
  • Notes state that CI runs the tests on every change while the local globs select only *.mjs and package.json, and list the CI checks with no local form: the pull-request contract check, the result aggregation, the two review lanes, check-managed-files.

Verification

  • All six records validate against the ecosystem-commands schema.
  • An independent review read every citation at the commit it names and compared every key with the CI step it mirrors: READY after one rework round on note wording.
  • test-cmd was run under bash -u -c with a stub npm that fails on test: the failure status comes through and validate is skipped, as in CI.
  • Run on the build host with the real tools: npm test 202 of 202, npm run validate 0 errors and 0 warnings, lychee 0.24.2 (CI's pin) 0 errors.
  • Not checked: which 24.x patch CI's setup-node resolves, and whether .lycheeignore is handled the same locally and in CI.

Known nit left as it is: a missing space between two sentences in the python record's notes.

Related

session: GitHub Support

🤖 Generated with Claude Code

kyle-sexton and others added 3 commits November 14, 2026 04:21
Add .claude/ecosystems/ records so /toolchain:check and /toolchain:lint
resolve this repository's own commands instead of the toolchain plugin's
bundled defaults. The records mirror CI's pr-require-checks.yml, with
deviations listed in each record's notes:

- typescript.yaml: npm test, then npm run validate (the
  validate-marketplace job).
- cross-cutting.yaml: lychee offline with lychee.toml (the lychee job),
  plus the CI-only checks with no local form.
- python, markdown, yaml and bash: enabled with null commands, because
  CI runs no command for them and the bundled defaults would otherwise
  run tools CI does not.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The bundled yaml default runs only actionlint; the bundled bash default
runs shfmt because this repository's .editorconfig declares shell style.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
CI runs the node tests on every change; the notes now say so once in
typescript.yaml, with examples of files that run no local test, and the
markdown and yaml cross-references match it. The node pin note names
.node-version as standards-synced, and python.yaml names the commands
the bundled Python default would run.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 14, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-14T09:33:46.491861Z 2057927 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions

Copy link
Copy Markdown

claude-security-review reviewed 20579279c9b43f7d802190892548c3d152fde645: 0 finding(s), 0 as inline comments.

No security findings in PR 183 at 2057927.

The PR adds six .claude/ecosystems/*.yaml records: bash, cross-cutting, markdown, python, typescript and yaml. They are configuration and prose only, with no workflow, manifest, hook, token or trusted-path changes.

  • Commands introduced: Only two records set a command. typescript.yaml runs npm test && npm run validate, the same two steps CI's validate-marketplace job already runs. cross-cutting.yaml runs lychee --offline --no-progress --config lychee.toml '**/*.md', which is offline, takes no interpolated input, and matches the lychee job in CI. A pull request author could already change what those commands execute by editing the repository's own test files, so this adds no new execution path.
  • Commands removed: The other four records (bash, markdown, python, yaml) set every command to null. That stops the bundled defaults from running shellcheck, shfmt, markdownlint, pytest, ruff, pyright and actionlint. This is a lint and test coverage reduction, not a security control. No instruction, rule, hook or validator is removed, so the instruction-surface lens finds nothing.
  • Secrets and external sources: The only digest is a lychee release-archive SHA-256 in install-hint, which is public integrity data. No secrets, tokens, absolute paths, unpinned external sources or URL-fed commands appear. The upstream links are documentation pointers only.
  • Embedded instructions: No imperative text aimed at a reviewer or lane appears in the diff. I read no PR context file because none was supplied.
  • Manifests: No plugin.json or marketplace.json is touched, so there are no manifest <field> lines.
  • Protected classes: I did not consult the instruction exception register, since the diff removes no standing instruction.

critical-findings: 0

@github-actions

Copy link
Copy Markdown

claude-review reviewed 20579279c9b43f7d802190892548c3d152fde645: 0 finding(s), 0 as inline comments.

No findings. This PR adds six .claude/ecosystems/*.yaml records and touches no code, so I reviewed it by checking the records' citations against the repository at the PR head.

What I checked, with tools I ran:

  • pr-require-checks.yml: the cited line ranges match.
    • The validate-marketplace job is at 74-91, with npm test at 89 and npm run validate at 91.
    • The lychee job is at 93-106 and the ci-status job at 108.
    • check-contract is at 131 and aggregate-results at 139.
    • There is no markdownlint, shellcheck, actionlint or Python step in the file, which supports the null-command records.
  • .node-version: it reads 24, which matches tool-pin.node: "24".
  • package.json: the test and validate scripts are at lines 11-12, as the typescript record says.
  • .editorconfig:46-48: the [*.{sh,bash}] section exists, as the bash notes say.
  • pr-check-managed-files-hosted.yml: it lists .claude/cloud-bootstrap.sh (39), .editorconfig (41), .editorconfig-checker.json (42), .gitleaks.toml (67), .markdownlint-cli2.jsonc (72), .node-version (73) and _typos.toml (76). The cited lines match.
  • lychee.toml: the config sets hidden = true, include_fragments = "full" and the exclude_path entries for .work/ and .claude/worktrees/. That matches the lychee notes.
  • Lychee command: the check-cmd mirrors CI's config: lychee.toml with the composite's default **/*.md glob. I could not read lychee-offline/action.yml or the pinned ci-workflows commit from here, so the :8, :19, :24, :40, :62 and :72-74 cites and the SHA-256 are unverified.
  • Not checked: the bundled-default citations in claude-code-plugins (plugins/toolchain/reference/ecosystems/*.yaml), the ecosystem-commands schema, and the PR's claims about test runs and lychee 0.24.2.

Closing issue: melodic-software/claude-code-plugins#15727 has a heading in the PR context file but no body or criteria. I could not read it, so I report nothing as met or unmet against it.

Path-scoped rules: the only rule file is .claude/rules/pr-body-contract.md, which governs PR title and body. The PR title is Conventional Commits, and the body has Closes, ## Summary, ## Fix, ## Verification and ## Related.

Not reported:

  • Missing space: the missing space in the python record's notes (pyright.The) is a style nit that the author already named.
  • Citation line offsets: a few are off by a line or two against the actual step headers; I did not report these.

Verifier dropped 0 of 0 candidates.

@kyle-sexton
kyle-sexton merged commit fd60de8 into main Nov 14, 2026
8 checks passed
@kyle-sexton
kyle-sexton deleted the chore/ecosystem-records branch November 14, 2026 09:34
kyle-sexton added a commit to melodic-software/cursor-plugins that referenced this pull request Nov 14, 2026
Refs: melodic-software/claude-code-plugins#15723

## Summary

Adds `.claude/ecosystems/` records (bash, cross-cutting, markdown,
powershell, typescript, yaml), so `/toolchain:check` and
`/toolchain:lint` run what this repository's CI runs and no bundled
default runs a tool CI does not.

## Fix

This repository's CI is mostly its own inline steps in
`pr-require-checks.yml`. Each record copies the step it cites by
`file:line`; the notes state the deviations, the checks not run locally,
and examples of glob gaps.

- `bash.yaml`: shellcheck and `bash -n` over CI's file list, and the two
shell test suites. CI stops at its first failing step; the check runs
every file and fails when any fails. No `tool-pin`: CI installs Ubuntu's
shellcheck package with no version.
- `powershell.yaml`: the analyzer call as in CI, with
`$ErrorActionPreference="Stop"` as GitHub sets for pwsh steps. The
suppressed-findings listing is dropped; it only prints.
- `markdown.yaml`: CI's SKILL.md frontmatter check. CI runs no
markdownlint here, and this record replaces the bundled default's
commands.
- `cross-cutting.yaml`: the docs-naming check, one `jq empty` per
manifest, the relative-link check, lychee offline and typos, with lychee
and typos pinned as CI pins them. Every command contributes to the
status.
- `yaml.yaml` and `typescript.yaml`: every command null, which stops the
bundled actionlint, tsc and Biome defaults. CI's schema step is not run
locally: it runs `npm init`, installs ajv without exact versions and
downloads schema files into the repository root, and a check command may
not install or write.
- The copied fragments name their result variable `fail`, not `status`
as CI does: `status` is read-only in zsh, so the copied form failed on
every zsh run.

## Verification

- All six records validate against the ecosystem-commands schema.
- An independent review read every citation, compared every command with
the workflow step it copies, and ran each check command with stub tools
under both `bash -u -c` and `zsh -c`: exit 0 when all pass, exit 1 when
any one tool or file fails. READY, no blocking finding.
- Run on the build host with the real tools, all passing: shellcheck
0.11.0, `bash -n` on each listed file, the sync-local suite (73 passed),
the docs-naming suite (9 passed), `check-docs-naming --check`,
PSScriptAnalyzer 1.25.0 (0 findings), jq, lychee offline 0.24.2, typos
1.52.1 (CI pins 1.50.3). The reviewer ran the relative-link check on the
real tree: exit 0.
- Not run: the markdown frontmatter check with real files by the builder
(the reviewer ran it: exit 0), and CI's schema step.

Known limits from the review, left as they are: the relative-link
fragment fails closed under zsh with `extendedglob` set (not this tool's
default); the powershell header cites `:149-153` where the block is
`:149-154`.

## Remaining

Issue melodic-software/claude-code-plugins#15723 stays open after this
pull request. Its done-when also asks for:

- a recorded `/toolchain:check all` output for this repository that
contains no `skip (unresolved`;
- the issue's baseline steps: one merged commit range touching each
ecosystem with both SHAs, the command list of a run with the bundled
defaults, and a re-run with these records whose command list matches
apart from the listed differences;
- this pull request's URL posted on the issue.

## Related

- melodic-software/claude-code-plugins#15703 (parent),
melodic-software/codex-plugins#183 (the same records there)

session: GitHub Support

🤖 Generated with [Claude Code](https://claude.com/claude-code)

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
kyle-sexton added a commit that referenced this pull request Nov 14, 2026
Refs: melodic-software/claude-code-plugins#15727

## Summary

Puts the local gitleaks secret scan back into
`.claude/ecosystems/cross-cutting.yaml`. The record merged in
#183 set no gitleaks command because no CI
job here runs one, and that switched off the scan the bundled toolchain
default ran for this repository. The owner had not approved removing a
secret scan.

## Fix

- `check-cmd` now runs lychee and then `gitleaks dir . --config
.gitleaks.toml --no-banner --redact`; each contributes to the status and
any failure fails the command.
- The notes state the line as a deviation from CI: no CI job here runs
gitleaks. The command, version (8.30.1) and checksum are those of the
gitleaks composite at melodic-software/ci-workflows v0.39.8, which this
repository does not call.
- `opt-in`, `install-hint` and `tool-pin` name gitleaks.
- One cite into `pr-automerge-dependabot.yml` moved by a line when the
job display names changed; it is corrected.
- `tests/codex-operations.test.mjs`: the made-up token on line 206 gets
an inline `gitleaks:allow` comment, the mechanism `.gitleaks.toml` names
for an intentional finding. Without it the scan reports one finding on a
clean tree.

## Verification

- The record validates against the ecosystem-commands schema.
- `gitleaks dir` 8.30.1 over this branch's tree: no leaks found. Before
the test-file comment it reported 1 (rule `generic-api-key`, the fixture
line).
- `node --test tests/codex-operations.test.mjs`: 22 passed, 0 failed.
- An independent review read every cite the change adds or moves,
compared the record key by key with the version on main, and ran the
command shape with stub tools: exit 0 when clean, exit 1 when gitleaks
finds something, errors or is missing. READY, no blocking finding.
- A probe on the build host showed `gitleaks dir` also reads untracked
and git-ignored files, as the notes say.

## Remaining

Issue melodic-software/claude-code-plugins#15727 stays open after this
pull request; its baseline steps and recorded `/toolchain:check all`
output are still owed.

Whether a record should keep other bundled checks that CI does not run
(typos, for example) is an open owner question; this pull request
changes only the secret scan.

## Related

- #183 (the records this corrects),
melodic-software/claude-code-plugins#15703 (parent)

session: GitHub Support

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-authored-by: Claude Fable 5.2 <noreply@anthropic.com>
kyle-sexton added a commit that referenced this pull request Nov 16, 2026
…200)

Refs: melodic-software/claude-code-plugins#15727

## Summary

Refreshes two stale citations in the notes of
`.claude/ecosystems/cross-cutting.yaml`. No command, glob or pin key
changes.

## Fix

- The notes named check-managed-files at `8e1076f` (v0.71.0).
#195 moved that pin to `944d346`
(v0.74.0), and #193 lets Dependabot move it again, so the note now names
it as the commit `pr-check-managed-files-hosted.yml:118` pins, the way
the lychee note already does.
- #194 added a header comment line to
`pr-automerge-dependabot.yml`, so its job is now `:22-30` (was cited
`:22-29`) and the sentence describing what it arms is `:3-8` (was
`:3-7`).

## Verification

- All six records validate against the ecosystem-commands schema
(`check-jsonschema`: `ok -- validation done`).
- Every other citation in the six records was read at `8f73ded`: the
`pr-require-checks.yml`, `pr-check-managed-files-hosted.yml` and both
review-workflow lines still hold. The lychee-offline composite at the
pinned `944d346` still defaults to lychee 0.24.2 with the recorded
checksum and arguments; the gitleaks composite there still pins 8.30.1.
- `/toolchain:check all` and `/toolchain:lint` (toolchain 1.4.3) with
these records, over the changed files of `2d92547..8f73ded` (51 files):
- check: `Overall: PASS (1 of 1 ecosystems that ran a command passed:
typescript; powershell: skip (opt-in unmet); bash, markdown, python,
dotnet, go: no command)`; `npm test` 202 of 202, `npm run validate` 0
errors.
- lint: `Overall: PASS (1 of 1 ecosystems that ran a command passed:
cross-cutting; bash, markdown, python, typescript, yaml: no command)`;
lychee 0 errors, gitleaks no leaks.

## Remaining

- melodic-software/claude-code-plugins#15727 closes after this merges,
with the recorded runs and baseline.
- Open question for the owner, not changed here: `typescript.yaml`'s
globs (`*.mjs`, `package.json`) are narrower than CI, whose
`validate-marketplace` job has no path filter. A change to only a
`SKILL.md`, `plugin.json` or `*.py` file runs no local test while CI
runs `npm test`. The notes state this gap. Matching CI would need
`globs: ["**"]`, which would also make code-metrics count every file as
typescript.

## Related

- #183 (the records),
#184 (the gitleaks line)

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add ecosystem records to codex-plugins

1 participant