Repository navigation
chore: add ecosystem records mirroring CI's checks - #154
Conversation
Add .claude/ecosystems/ records (bash, powershell, markdown, yaml, typescript, cross-cutting) so /toolchain:check and /toolchain:lint resolve this repository's own commands instead of the toolchain plugin's bundled defaults. The records mirror CI's checks in pr-require-checks.yml, cited by file:line; each deviation, each check not run locally and each glob gap is listed in that record's notes. The typescript and yaml records run no command and stop the bundled defaults, because CI runs no lint or build for those files and its schema step is not run locally. Refs: melodic-software/claude-code-plugins#15723 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The markdown frontmatter check and the cross-cutting relative-link check copied CI's result variable, status, which zsh holds read-only, so under zsh the assignment failed and the check could pass with a failing file. Name the variable fail in both records and say so in their notes. The powershell record's notes now say GitHub prepends $ErrorActionPreference = 'stop' to a pwsh step, so setting it in check-cmd matches CI; the -SuppressedOnly listing stays the deviation. Refs: melodic-software/claude-code-plugins#15723 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
claude-security-review reviewed Security review: no findingsI reviewed all 6 changed files. Each is a new
No critical-findings: 0 |
|
claude-review reviewed No findings on PR #154. I read the full diff and compared each record's commands with the
Verifier dropped 0 of 0 candidates. |
Refs: melodic-software/claude-code-plugins#15725 ## Summary Adds `.claude/ecosystems/` records (bash, cross-cutting, markdown, yaml), so `/toolchain:check` and `/toolchain:lint` run what this repository's CI runs and no bundled default runs a tool CI does not. ## Fix This repository's CI is inline steps in `pr-require-checks.yml`. Each record copies the step it cites by `file:line`; the notes state the deviations and the checks not run locally. - `bash.yaml`: shellcheck on CI's two scripts and `bash -n` on each, as CI's steps. CI stops at its first failure; the check runs all three commands and fails when any fails. `fix-cmd` is null so the bundled shfmt does not run. No `tool-pin`: CI uses the runner image's shellcheck. - `cross-cutting.yaml`: `jq empty` on the two JSON files CI checks, and lychee offline at CI's pinned version (0.24.2); `install-hint` gives the checksum CI verifies. Typos, gitleaks and editorconfig-checker are not run in CI here and get no command. - `markdown.yaml` and `yaml.yaml`: enabled with every command null, which stops the bundled markdownlint and actionlint defaults; CI runs neither. - The file lists in the bash and jq commands copy CI's literal lists and change when CI's change. There is no glob gap against CI: the workflow has no path filter, cross-cutting's globs select every file, and the bash globs select both scripts its commands read. If a `.shellcheckrc` is ever synced in, a change to it alone would change CI's shellcheck result without selecting the bash record. Not run locally, each listed in notes: the pull-request contract check, the result aggregation, the two review lanes, check-managed-files. ## Verification - All four records validate against the ecosystem-commands schema. - An independent review read the cited lines, compared every command with the workflow step it copies, confirmed no tracked file matches another bundled default, and ran both check commands with stub tools under `bash -u -c` and `zsh -c`: exit 0 when all pass, exit 1 when any one command fails, every later command still run. It found one false note sentence, corrected here with its wording. - Run on the build host with the real tools, all passing: shellcheck 0.11.0, `bash -n` on both scripts, `jq empty` on both files, lychee 0.24.2. The runner image's shellcheck version was not read. ## Remaining Issue melodic-software/claude-code-plugins#15725 stays open after this pull request. Its done-when also asks for: - a recorded `/toolchain:check all` output for this repository that contains no `skip (unresolved`; - the issue's baseline steps: one merged commit range touching each ecosystem with both SHAs, the command list of a run with the bundled defaults, and a re-run with these records whose command list matches apart from the listed differences; - this pull request's URL posted on the issue. ## Related - melodic-software/claude-code-plugins#15703 (parent), melodic-software/cursor-plugins#154 (the same records there) session: GitHub Support 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Refs: melodic-software/claude-code-plugins#15723 ## Summary Puts the local gitleaks secret scan back into `.claude/ecosystems/cross-cutting.yaml`. The record merged in #154 set no gitleaks command because no CI job here runs one, and that switched off the scan the bundled toolchain default ran for this repository. The owner had not approved removing a secret scan. ## Fix - `check-cmd` gains `gitleaks dir . --config .gitleaks.toml --no-banner --redact` as its last check; it contributes to the status like every other line. No existing check changes. - The notes state the line as a deviation from CI: no CI job here runs gitleaks. The command, version (8.30.1) and checksum are those of the gitleaks composite at melodic-software/ci-workflows v0.39.8, which this repository does not call. - `opt-in`, `install-hint` and `tool-pin` name gitleaks. - One cite into `pr-automerge-dependabot.yml` moved by a line when the job display names changed; it is corrected. ## Verification - The record validates against the ecosystem-commands schema. - `gitleaks dir` 8.30.1 over this branch's tree: no leaks found. - An independent review read every cite the change adds or moves, compared the record key by key with the version on main, and ran the command shape with stub tools: exit 0 when clean, exit 1 when gitleaks finds something, errors or is missing. READY, no blocking finding. - A probe on the build host showed `gitleaks dir` also reads untracked and git-ignored files, as the notes say. ## Remaining Issue melodic-software/claude-code-plugins#15723 stays open after this pull request; its baseline steps and recorded `/toolchain:check all` output are still owed. Whether a record should keep other bundled checks that CI does not run is an open owner question; this pull request changes only the secret scan. ## Related - #154 (the records this corrects), melodic-software/claude-code-plugins#15703 (parent) session: GitHub Support 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude Fable 5.2 <noreply@anthropic.com>
…the cross-cutting record (#166) Refs: melodic-software/claude-code-plugins#15723 ## Summary Since #154 and #156, #164 moved the check-managed-files pin to ci-workflows v0.74.0 (`944d346`), and #163 added a header line to `pr-automerge-dependabot.yml`. The cross-cutting record's notes still named v0.71.0 and line ranges one line short. This change corrects those three citations and nothing else. ## Fix - `check-managed-files@8e1076f v0.71.0` becomes `@944d346 v0.74.0`, matching `pr-check-managed-files-hosted.yml:118`. - `pr-automerge-dependabot.yml:21-29` becomes `:22-30` (the job), and `:3-7` becomes `:3-8` (the header sentence). No command, version or checksum changes. #162 also moved the lychee-offline and typos composites to v0.74.0. I diffed them against v0.39.8 (`594987a`): their version, sha256 and argument defaults are unchanged. lychee-offline moved its run step into `run.sh` unchanged, and it now falls back to a bundled `lychee.toml` only when the caller has none; this repository has one. The other records' citations still hold: apart from that header line, every CI edit since #156 changed lines in place. ## Verification - Schema: `check-jsonschema --schemafile docs/contracts/ecosystem-commands/ecosystem.schema.json` (claude-code-plugins `origin/main`) over all six records printed `ok -- validation done`. - Method: a throwaway `git clone --shared` of this branch, with `refs/remotes/origin/main` at #156's merge `c12a04f`. The range runs #157 through this commit: 16 files, covering workflows, dependabot, AGENTS.md, REVIEW.md, docs and five SKILL.md. Every tool runs with `env -C <clone>`. Toolchain skill text is 1.4.0. - Run 1, `/toolchain:check all`, 11:37 PM to 11:38 PM EST 2026-11-15. Overall line: `Overall: PASS (3 of 3 ecosystems passed)`. | Ecosystem | Build | Test | Lint | Status | |---|---|---|---|---| | bash | — | pass | pass | PASS | | powershell | — | — | pass | PASS | | markdown | — | — | pass | PASS | | typescript | — | — | — | — | - bash: the sync-local suite has 73 passed, 0 failed and 0 skipped (pwsh present), and the docs-naming suite has 9 ok. shellcheck and `bash -n` over CI's list exited 0. - powershell: PSScriptAnalyzer reported 0 findings. - typescript: every command is null. - No dotnet, python or go project files exist. - The output contains no `skip (unresolved`. - Run 2, `/toolchain:lint`, 11:38 PM to 11:39 PM EST. Overall line: `Overall: PASS (2 of 2 ecosystems passed)`. - markdown passed, and yaml is all null. - cross-cutting passed: check-docs-naming, jq, the relative-link check, lychee (0 errors), typos, and `gitleaks dir . --config .gitleaks.toml --no-banner --redact` (no leaks). - Installed typos is 1.52.2; the pin is 1.50.3. - The verify gate passed on this commit: schema validation plus the cross-cutting check-cmd. ## Remaining melodic-software/claude-code-plugins#15723 stays open after this pull request. Its baseline steps are still owed: a `/toolchain:check all` and a `/toolchain:lint` with the bundled defaults (records removed) on one range, then the comparison of their command lists with the record runs above. This pass had a two-run budget, which went to the record runs. ## Related - #154 and #156, which merged the records this change corrects - melodic-software/claude-code-plugins#15723, melodic-software/claude-code-plugins#15703 (parent) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Refs: melodic-software/claude-code-plugins#15723
Summary
Adds
.claude/ecosystems/records (bash, cross-cutting, markdown, powershell, typescript, yaml), so/toolchain:checkand/toolchain:lintrun what this repository's CI runs and no bundled default runs a tool CI does not.Fix
This repository's CI is mostly its own inline steps in
pr-require-checks.yml. Each record copies the step it cites byfile:line; the notes state the deviations, the checks not run locally, and examples of glob gaps.bash.yaml: shellcheck andbash -nover CI's file list, and the two shell test suites. CI stops at its first failing step; the check runs every file and fails when any fails. Notool-pin: CI installs Ubuntu's shellcheck package with no version.powershell.yaml: the analyzer call as in CI, with$ErrorActionPreference="Stop"as GitHub sets for pwsh steps. The suppressed-findings listing is dropped; it only prints.markdown.yaml: CI's SKILL.md frontmatter check. CI runs no markdownlint here, and this record replaces the bundled default's commands.cross-cutting.yaml: the docs-naming check, onejq emptyper manifest, the relative-link check, lychee offline and typos, with lychee and typos pinned as CI pins them. Every command contributes to the status.yaml.yamlandtypescript.yaml: every command null, which stops the bundled actionlint, tsc and Biome defaults. CI's schema step is not run locally: it runsnpm init, installs ajv without exact versions and downloads schema files into the repository root, and a check command may not install or write.fail, notstatusas CI does:statusis read-only in zsh, so the copied form failed on every zsh run.Verification
bash -u -candzsh -c: exit 0 when all pass, exit 1 when any one tool or file fails. READY, no blocking finding.bash -non each listed file, the sync-local suite (73 passed), the docs-naming suite (9 passed),check-docs-naming --check, PSScriptAnalyzer 1.25.0 (0 findings), jq, lychee offline 0.24.2, typos 1.52.1 (CI pins 1.50.3). The reviewer ran the relative-link check on the real tree: exit 0.Known limits from the review, left as they are: the relative-link fragment fails closed under zsh with
extendedglobset (not this tool's default); the powershell header cites:149-153where the block is:149-154.Remaining
Issue melodic-software/claude-code-plugins#15723 stays open after this pull request. Its done-when also asks for:
/toolchain:check alloutput for this repository that contains noskip (unresolved;Related
session: GitHub Support
🤖 Generated with Claude Code