Repository navigation
One-DOCX stay-or-go walk is the only review - #373
Merged
Merged
Conversation
Review one DOCX by walking that file with a stay-or-go loop at each level. Side effects write comments and text on the source path during the walk instead of emitting a new reviewed.docx only after post-order scans. Co-authored-by: Patryk Mikołajczyk <mikolaj92@users.noreply.github.com>
Docxtor treats existing comment markers as opaque, so a second identical range cannot be placed. Write that extra comment on the paragraph so it still sits on the sentence during the live walk. Co-authored-by: Patryk Mikołajczyk <mikolaj92@users.noreply.github.com>
Each zdanie, akapit, and rozdział has its own stay-or-go box. Stay recurses on that unit with a comment or text change on the same DOCX; go moves to the next numbered box. Całość stay walks the whole document again n times; go is done on that file. Co-authored-by: Patryk Mikołajczyk <mikolaj92@users.noreply.github.com>
review_docx walks zdanie, akapit, rozdział, then całość on the same file. Each unit has its own stay loop; stay count is however many times the reviewer stays. Side effects are Word comments and tracked insert, delete, and replace through Docxtor. Other review paths are gone: two-scan name-then-judge, review_tree, review_document writing a separate reviewed.docx, takt as a review, and the Pack pipeline. Co-authored-by: Patryk Mikołajczyk <mikolaj92@users.noreply.github.com>
cursor
Bot
changed the title
LiveDocx keeps a single DocxDocument for the walk and asks it to add, update, or delete a comment, and to tracked-insert, delete, or replace text, then publish that same path. Byte-level Docxtor APIs and apply_replacements are gone. The stay-or-go walk remains the only review. Co-authored-by: Patryk Mikołajczyk <mikolaj92@users.noreply.github.com>
mikolaj92
marked this pull request as ready for review
October 4, 2026 09:37
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
LiveDocx.delete_comment now uses the open-handle method. A later stay that adds another comment on the same sentence still goes through Docxtor: add_comment first, then add_paragraph_comment when the occupied span is opaque. Tests pass against the 0.15.0 pin. Co-authored-by: Patryk Mikołajczyk <mikolaj92@users.noreply.github.com>
Drop leftover review paths and the notes that sat beside them: Pack research, Takt three-scan notes, old release changelog, text-tree parser, footnote reader, and the notice pack fixture. The public surface is the zdanie → akapit → rozdział → całość walk on one Docxtor handle. Pin stays 608336b0. Co-authored-by: Patryk Mikołajczyk <mikolaj92@users.noreply.github.com>
The walk does not call Takt. Research notes, changelog, and release notes that named it are already gone. Tests no longer mention TaktReviewer or takt. Co-authored-by: Patryk Mikołajczyk <mikolaj92@users.noreply.github.com>
AGENTS.md now states the stay-or-go walk and nothing else. FALLBACKS.md is gone. Fala, Dike, Argus, and Temida are not mentioned. Co-authored-by: Patryk Mikołajczyk <mikolaj92@users.noreply.github.com>
Byte-level Docxtor functions are gone. LiveDocx uses DocxDocument.open then add_comment, update_comment, remove_comments, insert_revision, delete_revision, replace_revision, and publish on that same file. Co-authored-by: Patryk Mikołajczyk <mikolaj92@users.noreply.github.com>
The walk still uses one open handle: add_comment, update_comment, remove_comments, insert_revision, delete_revision, replace_revision, and publish. A later stay can add another comment on the same zdanie. Co-authored-by: Patryk Mikołajczyk <mikolaj92@users.noreply.github.com>
This was referenced Oct 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The stay-or-go walk of one DOCX is the only review.
review_docxopens that file and walks zdanie, then akapit, then rozdział, then całość. On a unit, stay or go. Stay may add, update, or delete a Word comment, or change text as tracked insert / delete / replace, through one open Docxtor handle. Go moves to the next unit.Pinned to Docxtor 0.17.0 at
4abb48008c18d668e755000c26a650a15349bc4b(v0.17.0). The walk uses only that open handle:add_comment,update_comment,remove_comments,insert_revision,delete_revision,replace_revision, andpublish(). Docxtor is not edited here.Walk tests against that pin: 29 passed, including a second Word comment on a sentence that already has one.
Checks are green (no failing required checks;
mergeable/CLEAN). Merging to main.