Repository navigation
Report a problem with the guide (v1.8.0): the flag, the window, the text for GitHub - #60
Merged
Merged
Conversation
The guide window's flag (beside the NPC directory's pin, reached up from the
pin in focus mode), the DING_REPORT binding and its chord, and /ding bug open
a Ding window that shows in plain words what the report will contain: the
guide, the step as the window numbers it and its index in the guide's file,
its summary and keys, the position, the character, the step's quests and the
log's quests the next 3 steps name with their counters, the arrow's target,
the route settings, the theme, TomTom, the versions and the date (UTC). Never
the character's name, the realm or the account.
Four ready reasons for a gamepad, the player's words with a keyboard (the box
never takes the keyboard from the chat), then "Create the text": GitHub
Markdown with English labels, selected for Ctrl+C, with the issue form's link.
The last 20 reports stay in DingDB.reports ("Restore all defaults" keeps
them) for a player who can only send the file.
Tests: report_test, the report window in dialog_layout_test and
single_action_test (every language, gamepad and mouse), a smoke scenario
with the gamepad alone.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
.github/ISSUE_TEMPLATE/ding-report.yml: "Paste the text Ding made here" and "What happened?". README: the feature, /ding bug and how to report a problem. CHANGELOG: the v1.8.0 entry. SPEC, architecture and UI handoff: the window, the text, DingDB.reports, the flag in focus mode. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Yendi: players must notice the button and feel invited to press it, and it must read as a problem with the guide, not a technical bug report. The flag now sits on a warm fill of its own in every theme (tokens report and onReport: Halo and Ardoise #FF6A3D, Bandes #FF7A50, Ding dark #FF7043; the flag at 6.5:1 or more on it, the fill at 6.5:1 or more on the window, unlike the accent), a lighter veil under the mouse, its tooltip in words: "Problem with this step?" and a line under it. The window's title and the binding: "Report a problem with the guide". No player-facing text says "bug" (the /ding bug command apart). Icon only: a word on it would cut the guide's title at the window's usual widths. Tests: every theme's fill, ink, contrast and focus ring; the tooltip; no "bug" in the report texts of the 8 languages. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Yendi, in game: the address first ("1. Open this address on GitHub:"),
selected first with its button on the left, then the text ("2. Copy this
text and paste it into the report:"), then how to copy and where the
reports are kept. The address was cut in its box ("...ding-repor"): 475
units in Noto Sans at 11 for a 488-unit box. It is now in 10 (432) and the
window is 560 wide like the import window (a 528-unit box).
Tests: the order, the buttons' order and chips, the address's width read
from the shipped font's own metrics.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…s leaves Yendi, in game: the focused "Select the text" showed "A Y Select the text". A focused button now carries A alone; its own key (Y) comes back once the focus leaves, and still works meanwhile. Each button keeps room for the wider of the two chips, so nothing moves with the focus. single_action_test: no control of the report window shows two glyphs, at every stop, under the mouse, in every language; report_test: the chips and the width of "Select the text" focused and not. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ayer" is a heading) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For v1.8.0. Players can send precise problem reports that the authors read on GitHub issues.
What the player sees
An orange flag in the guide window's title bar, right beside the NPC directory's pin. Its
tooltip says "Problem with this step?" and, below, "Tell the people who make the guide: Ding!
writes the report for you." The orange fill is a new theme token (
report/onReport) ineach of the four themes. The flag is at least 6.5:1 on its fill, and the fill at least 6.5:1
on the window. The fill is unlike each theme's accent. The color never carries the meaning
alone. The button is icon only: a word on it would cut the guide's title at the window's usual
width.
Other ways in: in focus mode, up from the first row reaches the pin, then the flag (or Left
/ Right between the two); A opens it. There is a key binding "Report a problem with the guide"
(
DING_REPORT, in Bindings.xml and the Keybinds tab, chord-able like the others) and/ding bug(also/ding report), listed in/ding helpin all 8 languages and in the README.The window "Ding! · Report a problem with the guide" (a Ding dialog,
DingPadInputnavigation) shows in plain words what the report will contain, before anything is made:
What went wrong: four ready reasons with a radio ring: "The NPC is not there", "The arrow
points to the wrong place", "The quest is not offered", "Something else". With a gamepad, A
picks one and the focus moves to "Create the text". "In your words (optional)" is a box. With
a keyboard it takes the focus at once, but never from the chat: after
/ding bugtyped in thechat, it waits and says so (same fix as the export popup, Import window: never take the keyboard from the game's chat (the "AddOn blocked" popup on /ding export) #20).
"Create the text", in the order the player goes:
"Select the link" and "Select the text" (Y) each select their box. A line says Ctrl+C copies
and that an addon cannot write the clipboard. Each control shows one gamepad glyph: A on the
focused one, Y back on "Select the text" once the focus leaves.
Kept reports: Ding keeps the last 20 reports in
DingDB.reports. They are not a setting,so "Restore all defaults" keeps them. The window tells a player without a keyboard where the
file is (
WTF\Account\<account>\SavedVariables\Ding.lua).The text (GitHub Markdown, English labels, the player's words as typed)
The first line can be the issue's title. Quest names are in English, plus the client's name when
it differs. The step's keys are written as a guide writes them (
Import:StepText, withouttext, note or why).
In the repository
.github/ISSUE_TEMPLATE/ding-report.yml: an issue form with "Paste the text Ding made here"(required) and "What happened?" (optional). There is no
config.yml, so blank issues stayallowed. The link opens the form once this is on main.
Ding/Core/Report.lua(the facts, the text, the kept reports) andDing/UI/Report.lua(the window). The flag is added inPanel.lua. New helpers:Data:QuestEnglishName,Import:StepText,GuideText.Write { inline = true }.## v1.8.0entry.Tests
report_test(15 tests): the flag beside the pin, its look in every theme (fill, ink,contrast, focus ring) and its tooltip; the focus order; the binding, the chord, the Keybinds
row,
/ding bugand/ding help; the parts in plain words; the text (step, position,objectives with counters, comment, title line; no character name, realm or raw
|); thereasons with a gamepad; the chat keeping the keyboard; mouse versus gamepad chips; the 20 kept
reports; no guide or no position; combat; the GitHub address's width read from the shipped
Noto Sans metrics; no "bug" in any player-facing report text.
dialog_layout_test: both pages in every language, gamepad and mouse: nothing overlaps,nothing leaves the window.
single_action_test: each action shows once with one glyph per control, at every stop, underthe mouse, in every language.
GetBuildInfo,GetRealmName,H.player.name.Full suite
tools/check_all.shon a clean QuestieDB v1.0.6 export, with origin/main (v1.7.1)merged in: ALL GREEN (83 unit test files, 12 smoke runs, 0 problems).
To check in game
/ding bugfrom the chat with the gamepad interface on: no "AddOn blocked" popup.DingDB.reportsin the SavedVariables file after /reload.🤖 Generated with Claude Code