Chore/20251014#299
Conversation
|
WalkthroughBumps pnpm from 10.17.0 (and some earlier pins) to 10.18.3 across CI workflows and packageManager fields. Also updates numerous dependency and devDependency versions in fdm-app, fdm-docs, fdm-core, root package.json, and pnpm-workspace.yaml. No source code or exported API changes. Changes
Sequence Diagram(s)(omitted — changes are dependency and CI/tooling version bumps with no control-flow modifications) Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## development #299 +/- ##
============================================
Coverage 93.07% 93.07%
============================================
Files 81 81
Lines 13125 13125
Branches 1327 1327
============================================
Hits 12216 12216
Misses 907 907
Partials 2 2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Actionable comments posted: 0
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
fdm-app/package.json (1)
79-79: Move vite-node to devDependenciesvite-node isn’t imported by any runtime code; move it to devDependencies to avoid shipping it in production installs.
"dependencies": { - "vite-node": "^3.2.4", }, "devDependencies": { + "vite-node": "^3.2.4", }
🧹 Nitpick comments (1)
fdm-docs/package.json (1)
22-25: Align Docusaurus version pinning for consistencyOther Docusaurus packages are pinned to 3.9.1 while @docusaurus/faster uses a caret. Consider pinning it to 3.9.1 to avoid unexpected minor bumps. If you prefer caret here, note the rationale.
Also applies to: 33-35
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (11)
.github/workflows/deploy-docs-test.yml(1 hunks).github/workflows/deploy-docs.yml(1 hunks).github/workflows/release.yml(1 hunks).github/workflows/tests.yml(3 hunks)fdm-app/package.json(3 hunks)fdm-calculator/package.json(1 hunks)fdm-core/package.json(2 hunks)fdm-data/package.json(1 hunks)fdm-docs/package.json(2 hunks)package.json(1 hunks)pnpm-workspace.yaml(1 hunks)
🧰 Additional context used
🧠 Learnings (2)
📚 Learning: 2025-05-28T07:57:19.217Z
Learnt from: SvenVw
PR: SvenVw/fdm#147
File: fdm-docs/package.json:39-39
Timestamp: 2025-05-28T07:57:19.217Z
Learning: In pnpm workspaces, the syntax `"typescript": "catalog:"` is valid and correct. It references the version defined in the workspace's catalog section in pnpm-workspace.yaml, allowing consistent dependency versions across packages in a monorepo. The catalog: syntax without a package name is the shorthand for referencing the default catalog.
Applied to files:
pnpm-workspace.yamlfdm-calculator/package.json
📚 Learning: 2025-05-28T07:57:19.217Z
Learnt from: SvenVw
PR: SvenVw/fdm#147
File: fdm-docs/package.json:39-39
Timestamp: 2025-05-28T07:57:19.217Z
Learning: In pnpm workspaces, the syntax `"typescript": "catalog:"` is valid and correct. It references the version defined in the workspace's catalog section in pnpm-workspace.yaml, allowing consistent dependency versions across packages in a monorepo.
Applied to files:
fdm-calculator/package.json
🔇 Additional comments (6)
fdm-docs/package.json (3)
56-56: pnpm toolchain bump LGTM
38-38: typedoc-plugin-markdown v4.9.0 compatibility: v4.9.0 supports TypeDoc 0.28.x.
29-30: React 19 support confirmed in Docusaurus v3.9.x
Peer ranges (^18.0.0 || ^19.0.0) in Docusaurus and @docusaurus/faster cover React 19, so no compatibility issues remain.fdm-app/package.json (2)
109-109: pnpm toolchain bump LGTM
61-69: React 19 upgrade: ensure build and peer compatibility
- Install workspace deps:
pnpm install, thenpnpm --filter fdm-app install- Confirm
pnpm --filter fdm-app run typecheckandpnpm --filter fdm-app run buildsucceed- Verify peer ranges for @react-email/components, react-day-picker, react-map-gl, @sentry/react-router, remix-utils, remix-toast, and @react-router/*
pnpm-workspace.yaml (1)
9-24: Catalog version bumps look goodNo issues spotted. After merge, run:
pnpm install --frozen-lockfile=false 2>&1 | rg -ni "peer dep warning|unmet peer" || trueto surface any peer dependency warnings across the workspace.
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (2)
fdm-app/package.json(2 hunks)fdm-docs/package.json(2 hunks)
Summary by CodeRabbit