Skip to content

Keep Voxtype on CPU for Intel Haswell GPUs - #11481

Open
yashranaway wants to merge 8 commits into
omacom:quattrofrom
yashranaway:fix/voxtype-legacy-intel-vulkan
Open

yashranaway wants to merge 8 commits into
omacom:quattrofrom
yashranaway:fix/voxtype-legacy-intel-vulkan

Conversation

@yashranaway

@yashranaway yashranaway commented Sep 12, 2026 •

Copy link
Copy Markdown
Contributor

Keeps dictation on the CPU on Haswell machines where the Vulkan backend crashes during model loading. Addresses #11370.

<<<< AI wording below >>>>

Problem

The dictation installer treats an installed Vulkan ICD as sufficient GPU support. On Haswell, the reported ggml backend aborts because the device lacks the required 16-bit storage, and the service restarts repeatedly.

Addresses the Haswell crash loop in #11370.

Fix

Select CPU dictation on Intel Haswell GPUs for fresh and existing installations. The migration clears start-limit failures and restarts active or failed services, while leaving intentionally stopped services stopped. Other GPUs and machines without dictation are unchanged.

Verification

bash test/shell.d/voxtype-gpu-selection-test.sh passes. Changed Bash files pass syntax checks and git diff --check passes. No Haswell hardware was available.

Fixes #11370

@csfh csfh left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ryanrhughes

This looks good.

@omarchybot omarchybot added bug Something isn't working compatibility Make Omarchy work better on everything! labels Sep 27, 2026
@omarchybot

Copy link
Copy Markdown
Collaborator

Reviewed at 23f4aef by Claude Opus 5.5, with Codex at medium effort as a second opinion. No defects found in the diff. It now needs someone with Haswell hardware to confirm it, because no worker can run a Haswell GPU.

What was checked

  • The PCI pattern in bin/omarchy-hw-intel-haswell-gpu covers exactly the 60 IDs in Linux's INTEL_HSW_IDS, and it matches the lowercase 0x%04x form that sysfs prints.
  • On a worker built from the Omarchy ISO, test/shell.d/voxtype-gpu-selection-test.sh passes. I also wrote a separate reproduction, with voxtype stubbed and a Crystal Well device (0x0d26) under a fake sysfs tree. On the base branch the installer runs voxtype setup gpu --enable. On this head it runs sudo voxtype setup gpu --disable and then voxtype setup systemd. With the installer change reverted, --enable comes back. The head merged with current quattro behaves the same.
  • ./test/cli stops at vscode generated theme references current theme file. It stops at the same place on this branch's merge base, so the failure is not caused by this change.
  • On the worker I installed the real voxtype-bin and checked two exit codes. sudo voxtype setup gpu --disable exits 0, even when voxtype is already on CPU, so the new call cannot abort the installer under set -e. Running voxtype setup gpu --enable as a normal user fails with Permission denied, and || true hides the failure. So on quattro today the installer never puts a machine on Vulkan in the first place.

What was found

The Haswell machines that are crashing today most likely got Vulkan from the dropped migration 1775241210.sh. It ran sudo voxtype setup gpu --enable on every machine with a Vulkan ICD, and voxtype-bin's upgrade scriptlet has kept that backend since. This PR resets those machines only when the installer runs again. The menu's Install › Dictation entry is disabled while voxtype-bin is installed (default/omarchy/omarchy-menu.jsonc:245), so an affected user has to remove Dictation and install it again, or run omarchy-voxtype-install from a terminal. A migration would reach them on their next update. Whether to add one is the maintainer's decision, so nothing was pushed. Codex raised the menu point; I confirmed it in the source. On everything else Codex agreed with my reading, and its independence is not guaranteed.

#13508 contains an identical copy of this Haswell detector and the same --disable branch, plus a separate change that enables Vulkan with sudo on other GPUs. The two conflict in bin/omarchy-voxtype-install. For #11370, both models judged this PR the proportionate fix; #13508's sudo enable is a separate change.

Waiting on

@llyorshch, you reported #11370 on the Iris Pro 5200. Could you confirm this fix on that machine? If you already switched to CPU by hand, run sudo voxtype setup gpu --enable first, so the installer has a Vulkan selection to reset. Then:

git clone https://github.com/yashranaway/omarchy.git ~/omarchy-11481
git -C ~/omarchy-11481 checkout 23f4aeffda1a17aca66ca389e924840952426ab1
mkdir -p ~/omarchy-11481-bin && cp ~/omarchy-11481/bin/omarchy-hw-intel-haswell-gpu ~/omarchy-11481-bin/
PATH="$HOME/omarchy-11481-bin:$PATH" bash ~/omarchy-11481/bin/omarchy-voxtype-install
voxtype setup gpu --status
systemctl --user restart voxtype
journalctl --user -u voxtype -n 50

The installer should print Using CPU dictation: Intel Haswell Vulkan lacks the required 16-bit storage., the status should name a CPU backend, the journal should show no ggml_vulkan abort, and F9 dictation should work. After that it goes to the maintainer.

@greptile-apps

greptile-apps Bot commented Oct 1, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] The PR appears safe to merge; no new actionable failure was established.

Summary

The PR detects Intel Haswell GPUs and keeps Voxtype on CPU during installation and migration. The migration also recovers failed user services while leaving stopped services stopped.

  • Fresh and repeat installations skip or disable GPU selection on Haswell.
  • Tests cover PCI detection, installer selection, and migration service states.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart TD
  A[Voxtype installation or migration] --> B{Haswell GPU?}
  B -- No --> C[Keep normal GPU selection]
  B -- Yes --> D[Disable Voxtype GPU backend]
  D --> E{Migration: service active or failed?}
  E -- Yes --> F[Reset failure state and restart]
  E -- No --> G[Leave stopped service stopped]
Loading

Reviews (4) · Last reviewed commit: "Stub translated Voxtype notifications in..." · Reviewed by Greptile

Comment thread migrations/1790886353.sh Resolved
@yashranaway

Copy link
Copy Markdown
Contributor Author

Added a migration for existing Haswell installs that resets voxtype to CPU and only restarts an already-running service. The migration regressions pass; I have no Haswell hardware to retest.

@csfh

csfh commented Oct 2, 2026

Copy link
Copy Markdown
Member

LGMT @omarchybot

@omarchybot

Copy link
Copy Markdown
Collaborator

Thanks for adding the migration. It answers the open point from the last review, which was that machines already on Vulkan were only reset when the installer ran again.

This head (12edf22) has not been fully reviewed yet. Every item here gets two independent reviews, one by Claude Opus 5.5 and one by Codex. Codex is reachable, but today's limit on its reviews has been used up. So its classification of this head and its review of migrations/1790886353.sh have not happened. Nothing has been run on a worker for this head either. The classification is therefore unsettled at this head. The bug and compatibility labels stay from the earlier agreed review, which was done on 23f4aef.

On the next pass, the migration will be reviewed by both models and its test run on a worker. After that, it still needs confirmation on Haswell hardware, which no worker has. That pass will update the steps for testing on Haswell to cover the migration. Until it does, @llyorshch, please test this new head rather than the commit named in the earlier comment.

@omarchybot omarchybot removed bug Something isn't working compatibility Make Omarchy work better on everything! labels Oct 2, 2026
@llyorshch

Copy link
Copy Markdown

Tested 12edf22 on the #11370 machine: i7-4770HQ, Iris Pro 5200 (Crystal Well 8086:0d26), omarchy 4.0.4-1, voxtype-bin 1.1.0-2. The fix works.

  • omarchy-hw-intel-haswell-gpu returns 0 on the real sysfs. voxtype-gpu-selection-test.sh gives 6/6 ok.
  • Before: with Vulkan selected, voxtype crash-loops (ggml_vulkan: device Vulkan0 does not support 16-bit storage → Result=core-dump, NRestarts=4).
  • Migration 1790886353.sh (run with bash -euo pipefail while the service was crash-looping) exits 0 and switches to CPU (AVX2). The service is active/running, the model loads on CPU, there are 0 ggml_vulkan lines and transcription works.
  • Installer (with Vulkan selected beforehand) prints Using CPU dictation: Intel Haswell Vulkan lacks the required 16-bit storage. and ends on CPU with the same clean result.

Unrelated to this PR: the installer exited 1 on its last line with Call failed: The name is not activatable. omarchy-notification-send ran right after omarchy-restart-shell, before the new shell had re-registered org.freedesktop.Notifications, so the "Dictation Ready" toast was lost. quattro has the same lines.

@omarchybot omarchybot added bug Something isn't working compatibility Make Omarchy work better on everything! labels Oct 15, 2026
@omarchybot

Copy link
Copy Markdown
Collaborator

Reviewed at 8ebb2b2 by Claude Opus 5.5, with Codex at medium effort as a second opinion. No defects found. The fix needs one more confirmation on Haswell hardware at this head, because the installer changed since it was tested there.

What was checked

  • Since 12edf22, which @llyorshch confirmed on the Iris Pro 5200, the only change to what runs is the merge of quattro. Upstream renamed the installer to bin/omarchy-install-dictation-voxtype and rewrote it, so the Haswell logic was carried across by hand. The detector and migrations/1790886353.sh are byte-identical to the tested commit. The installer still skips enabling Vulkan on Haswell (line 23) and still resets an existing selection with sudo voxtype setup gpu --disable on every run (lines 30–32). Other machines take the same path as on quattro. One visible difference: the merged installer no longer prints Using CPU dictation: Intel Haswell Vulkan lacks the required 16-bit storage., which only changes the output.
  • On a worker built from the Omarchy ISO, voxtype-install-test.sh, voxtype-gpu-selection-test.sh and dictation-test.sh pass at this head, and so does ./test/cli. Against the base branch, the Haswell installer test and the migration test fail. With only the installer reverted to quattro, the Haswell installer test fails again. These tests stub voxtype and sysfs. They prove which backend gets selected, not that ggml stops aborting, and the hardware confirmation is what proves that.
  • Codex agreed. It found the merge resolution keeps the tested behaviour, that 0x0[4acd][012][26abe] matches exactly the 60 IDs in Linux's INTEL_HSW_IDS, that the migration is safe under bash -euo pipefail, and that the change is proportionate. It reached the same conclusions as this review, and its independence is not guaranteed.

This pull request now closes #11370 when merged. #13508 still carries an identical copy of the Haswell detector alongside its change to enable Vulkan on other GPUs, and the two conflict in the installer. This one is older and is the proportionate fix for #11370.

Waiting on

@llyorshch, thank you for the thorough test of 12edf22. Could you repeat it on 8ebb2b2? First put voxtype back on Vulkan with sudo voxtype setup gpu --enable, so there is a selection to reset. Then:

git clone https://github.com/yashranaway/omarchy.git ~/omarchy-11481
git -C ~/omarchy-11481 checkout 8ebb2b2934784ba2022ddb6b39c22a5e9f84527f
PATH="$HOME/omarchy-11481/bin:$PATH" bash -euo pipefail ~/omarchy-11481/migrations/1790886353.sh
voxtype setup gpu --status
sudo voxtype setup gpu --enable
OMARCHY_PATH="$HOME/omarchy-11481" PATH="$HOME/omarchy-11481/bin:$PATH" bash ~/omarchy-11481/bin/omarchy-install-dictation-voxtype
voxtype setup gpu --status
journalctl --user -u voxtype -n 50

Both --status calls should name a CPU backend, the journal should show no ggml_vulkan abort, and F9 dictation should work. After that it goes to the maintainer.

@llyorshch

Copy link
Copy Markdown

Retested at 8ebb2b2 on the same MacBook Pro (i7-4770HQ, Iris Pro 5200 / Crystal Well 8086:0d26, omarchy 4.0.4-1, voxtype-bin 1.1.0-2), following the steps above. It works.

  • Started from Vulkan: sudo voxtype setup gpu --enable, so /usr/bin/voxtype -> /usr/lib/voxtype/voxtype-vulkan.
  • bash -euo pipefail migrations/1790886353.sh: Switched to CPU (AVX2) backend., exit 0. voxtype setup gpu --status: Next launch: CPU (AVX2).
  • sudo voxtype setup gpu --enable again, then omarchy-install-dictation-voxtype: Switched to CPU (AVX2) backend., exit 0, service restarted. voxtype setup gpu --status: Active backend: CPU (AVX2) (daemon pid 11968). Whisper logs use gpu = 0.
  • journalctl --user -u voxtype since the start of the test has no ggml_vulkan, abort or 16-bit storage lines. coredumpctl shows no voxtype dumps.
  • F9 push-to-talk: 3 dictations, each transcribed in ~3 s on CPU (e.g. Transcribed: "And this looks like it's working.").

The installer left my existing config.toml and voxtype.service byte-identical.

@omarchybot omarchybot added verified Omarchy Triage has verified that this issue is ready for final review ready Good to merge labels Oct 15, 2026
@omarchybot

Copy link
Copy Markdown
Collaborator

Thank you, @llyorshch. Your retest confirms the fix at 8ebb2b2 on the Iris Pro 5200 that #11370 was reported from. Starting from Vulkan both times, the migration and the installer each switched voxtype to CPU. Afterwards the journal had no ggml_vulkan abort and no core dumps, and F9 dictation worked.

That was the last thing open. Earlier at this same head, the tests passed on a worker built from the Omarchy ISO, including ./test/cli and the voxtype tests, and Claude Opus 5.5 and Codex at medium effort both reviewed the diff and found no defects. This time Codex checked your report against the steps that were asked for and the code at this head. It found every step covered and nothing inconsistent. quattro has moved by one commit since then, which only adds lines to install/omarchy-other.packages, and the branch still merges cleanly.

The pull request is now labelled verified and ready, and it waits on the maintainer. #13508 still carries an identical copy of the Haswell detector and conflicts with this one in the installer.

@omarchybot omarchybot removed the ready Good to merge label Nov 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working compatibility Make Omarchy work better on everything! verified Omarchy Triage has verified that this issue is ready for final review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Voxtype install enables Vulkan on Haswell (hasvk) GPUs, causing an endless SIGABRT crash loop

4 participants