Repository navigation
Enable Voxtype GPU backend through sudo - #12901
chessing234 wants to merge 8 commits into
Conversation
Without elevation the symlink rewrite fails and the old || true left a silent CPU backend while the installer still reported success.
|
Verified: No production defect found in the tested scope at
The new regression test passes on this head and fails against the baseline installer at the expected sudo assertion. Optional test improvement: In Review informationTest scope: Source inspection and isolated baseline/head tests with mocked dependencies. Actual privilege escalation, GPU switching and Vulkan dictation were not tested; recovery from a partially completed real switch is unverified. Community review: Independent automated community review, unaffiliated with the Omarchy team, intended to help prepare PRs for their review. Automated AI review: Astra initial inspection, independent Opus 5 and Astra technical reviews, followed by verification of the reported claims against targeted evidence. |
|
thanks — nothing further on my side |
|
Thanks, @chessing234. This fix works as described. I tested it at
I've linked #7099 as well as #11110, since both report this bug. There's one consequence for the maintainer to weigh. Because the GPU step can now succeed, it also succeeds on Intel Haswell GPUs. #11370 reports that #13508 is a competing fix for the same bug. It also runs the switch under Reviewed by Claude Opus 5.5. The second opinion, Codex Medium, did not run: today's review quota was spent. So nobody else has checked this yet. This is waiting on the maintainer to choose between this and #13508, and to decide whether #11481 lands first. |
…aller omacom#14552 replaced bin/omarchy-voxtype-install with bin/omarchy-install-dictation-voxtype, which still runs `voxtype setup gpu --enable || true` as the user. The fix moves to the new installer unchanged, and the test now drives that script with a fresh config directory each run, since the GPU step only runs when no Voxtype config exists yet. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
#14552 replaced I tested 1c65793 on a disposable Omarchy VM with the real
Codex Medium reviewed the ported change as a second opinion. It found the merge faithful and the change proportionate. It raised one point I had already raised on the previous head, so its agreement there is not fully independent: once the switch can succeed, Intel Haswell machines get One thing for the maintainer: the GPU step now runs only on a first install. Anyone who installed dictation while this bug was live keeps the CPU build when they rerun the installer, because their config already exists. Fixing those machines would need a migration, which is beyond this pull request. This is waiting on the maintainer to decide the order with #11481. |
[Medium impact] The PR appears safe to merge; no new actionable issues were found. SummaryThe installer now runs GPU setup through
Reviews (6) · Last reviewed commit: "Merge upstream quattro" · Reviewed by Greptile |
The success case only checked that the elevated call ran and the install finished, so an installer that warned even after the switch worked would still pass. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Greptile left two review comments on 1c65793. Here is what I found for each. The success test didn't check that the switch worked ( Existing users miss the fix ( Codex Medium reviewed the new commit and both points as a second opinion. It agreed on both, and since my reasoning was already written down, that agreement is not fully independent. It found nothing new beyond the Haswell point that is already open. This is still waiting on the maintainer to decide the order with #11481, which adds the Haswell check and, like #13508, no longer merges cleanly. |
quattro now enables the GPU backend only when voxtype-vulkan is installed, since aarch64 voxtype-bin ships none. The switch keeps that check and still runs under sudo with a warning on failure. Both Voxtype install tests stub sudo and point the installer at a stub backend binary, so neither reaches the real one.
|
This stopped merging again because I tested 04a7836 on a disposable Omarchy VM with the real
Claude Opus 5.5 did the merge and the testing. Codex Medium reviewed the merge as a second opinion. It found no problems: both sides survive, the test changes keep every assertion, and the change is proportionate. It was agreeing with reasoning I had already written down, so that agreement isn't fully independent. The open points from before still stand. Once the switch can succeed, Intel Haswell machines get This is waiting on the maintainer to decide the order with #11481 and to choose between this and #13508. |
|
I reviewed 298af23, which adds the retry for existing configs and moves the sudo coverage into The fix works.
I've linked #7099, which reports the same Moving the switch out of the config check has side effects. The switch now runs on every run of the installer, and
Repairing installs that ran into this bug can't currently be told apart from overriding someone's own choice. #13508 switches only when the active binary is an AVX2 or AVX-512 build. That would leave ONNX users alone, but not someone who ran Claude Opus 5.5 did the review and testing. Codex Medium and muse-wonder (via pi, thinking high) gave second opinions. Both agreed the I didn't push anything, because what should happen on a rerun is a decision about behaviour. Earlier I raised that existing installs stay on CPU, and the retry answers that point. This is waiting on the maintainer to decide whether rerunning the installer should switch to GPU again, and in which order to land this and #11481. I compared this with #13508, which makes the same |
Voxtype’s GPU setup rewrites /usr/bin/voxtype. Running it without sudo failed and silently left the CPU backend selected. Run that step through sudo and warn when it fails.
GPU setup now runs outside the config-copy guard as well: an earlier failed attempt may already have created config.toml, and rerunning the installer must repair the backend while preserving custom settings. The Vulkan-runtime and executable-backend checks still gate the GPU step, including packages that do not ship a usable Vulkan binary.
Closes #11110.
Validation:
These tests exercise the real installer with command-boundary stubs. They do not attest physical GPU acceleration.
Prepared with AI assistance (Cursor/Codex).
Latest Linux validation after merging quattro (6194f46): all seven Voxtype installer cases pass in the VM. CI run and downloadable logs. Review and i18n checks pass. The full VM check is not green: its only failing file is the unchanged background-intro-lifecycle-test.sh (
app retints also wait through the opening crossfade), also observed on the config-only PR. No background/animation code is changed here.Fixes #7099