Repository navigation
Bound fingerprint retry attempts with exponential backoff (#13748) - #13819
szaidi-code wants to merge 1 commit into
Conversation
Independent community review
Tested: Fingerprint retry timing, exponential backoff progression, attempt capping, recovery on user wake ( Result: The changes function cleanly as intended:
Testing details
|
|
The cap + exponential backoff (250→4000ms, max 15) is the right shape for #13748, and resetting on success / fresh lock / wake after exhaustion looks correct. Please coordinate with the older fingerprint-retry cluster before this lands alone: #10393 (cap + closed-lid skip + polkit/sudo PAM silence), #11918 (backoff on immediate fail), and #12461 (stop the loop rather than only slow it). Those cover cases this PR does not (lid closed, polkit). Prefer one canonical fix, or stack the missing pieces onto this one. |
|
Reviewed by Opus 5.5 in Claude Code, with Codex Medium as a second opinion that read all the competing diffs separately and reached the same conclusion. Neither model ran the change on a worker: once a competing fix had already been chosen, verifying this one would not have changed what happens to it. This fixes the retry storm from #13748, but it is one of several open pull requests fixing the same loop in That timing distinction is also where this pull request is weaker. Both models found that the 15-attempt budget counts every unsuccessful completion, including the ordinary 30-second Next step is the maintainer's: choose between the competing fixes. The |
|
Closing as superseded by merged #7158. The merged retry policy handles repeated device errors with capped backoff and recovery, superseding the separate retry-budget fix. GPT-6 in Codex and Claude Opus 5.5 Medium checked the coverage against the landed source; Claude's agreement does not guarantee independence. This closure review was read-only and did not rerun runtime tests. |
Summary
Fixes #13748.
When the lock screen is left locked on machines with fingerprint readers configured,
Service.qmlpreviously retried authentication unconditionally on every failure and PAM error every 250ms with no retry ceiling and no backoff. When sensors report persistent errors (such as Broadcom or libfprint-tod thermal protection), this created an unbounded retry storm (e.g. over 100,000 attempts overnight) that overheated and disabled the sensor.Changes
fingerprintRetryTimer.intervalfrom 250ms doubling up to 4000ms.fingerprintPam.onErrorandhandleFingerprintFinished()failure branches withfingerprintRetryTimer.attempts < 15.resetAuthenticationState())result === PamResult.Success)runWake()) if attempts were previously exhausted, re-enabling authentication when the user returns to the machine.test/shell.d/lock-blank-fingerprint-test.sh.