Repository navigation
Conversation
|
@greptile review |
[Medium impact] The PR appears safe to merge; no actionable issue remains in the reviewed changes. SummaryRestores password focus when the lock window becomes active or focus falls back to its empty content area.
Reviews (11) · Last reviewed commit: "Restore lock screen password focus when ..." · Reviewed by Greptile |
|
@greptile review |
|
@greptile review |
|
Thanks! Could you confirm this covers the suspend path in #14613? There the lid closes and the machine suspends, so I'm not sure |
faeac13 to
f972417
Compare
|
In addition to This directly handles the suspend/resume flow reported in #14613:
Linked #12587 in the commit description as well. |
|
@greptile review |
f972417 to
1d63d57
Compare
|
@greptile review |
|
Read at 1d63d57 by Claude Opus 5.5 in Claude Code. This pass stopped before verification: the second opinion (Codex Medium) answers, but omabot's daily budget of reviews is spent, so classifying this as a bug fix has not been confirmed by a second model, and omabot does not test or label an item until two models agree on what it is. Nothing was run on a worker, and no labels were added. One thing the next pass and the maintainer will need: #8560 makes the same fix to Waiting on the next review pass, once the second opinion is available again; the choice between the two fixes is the maintainer's. |
1d63d57 to
a258669
Compare
a258669 to
0135402
Compare
0135402 to
d55d05a
Compare
d55d05a to
9f79c20
Compare
9f79c20 to
d842e25
Compare
d842e25 to
391c3c9
Compare
|
Reviewed at Competing fixes. Several open pull requests fix this same focus loss in Against that, this change acts in fewer cases. Both handlers return early unless This pull request stays open. Choosing between the fixes is the maintainer's decision, and nothing is needed from you for now. |
|
Closing as resolved upstream by #17277, which added |
Summary
When waking up from DPMS display blanking or system suspend/resume, the lock screen's password input field can lose active focus. Previously,
LockViewonly invokedforcePasswordFocus()on component completion and wheninputEnabledtransitioned to true, leaving the field unfocused upon display wake unless explicitly clicked.Fixes #14613
Solution
shell/plugins/lock/LockView.qml, add anonDisplaysBlankChangedhandler that re-requests focus viaQt.callLater(forcePasswordFocus)when!displaysBlank && inputEnabled.passwordActiveFocusonLockViewfor focus state assertions.test/shell.d/lock-wake-focus-test.shandtest/shell.d/fixtures/lock-wake-focus/shell.qml.Verification
./test/cliandtest/shell.d/lock-wake-focus-test.sh.