Repository navigation
Conversation
There was a problem hiding this comment.
Pull request overview
Replaces the terminal-based screensaver with a packaged native Wayland client while preserving the launcher entry point.
Changes:
- Delegates screensaver launches to the native package.
- Installs the package for new and existing systems.
- Adds graceful shutdown handling and launcher tests.
Tip
If you aren't ready for review, convert to a draft PR.
Click "Convert to draft" or run gh pr ready --undo.
Click "Ready for review" or run gh pr ready to reengage.
Reviewed changes
Copilot reviewed 4 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
bin/omarchy-launch-screensaver |
Delegates to the packaged native executable. |
bin/omarchy-screensaver |
Removes the terminal child implementation. |
bin/omarchy-system-lock |
Gracefully terminates the native screensaver. |
install/omarchy-base.packages |
Adds the package to fresh installations. |
migrations/1786782462.sh |
Installs the package on existing systems. |
test/shell.d/launch-screensaver-test.sh |
Tests launcher delegation and failure behavior. |
test/shell.d/system-lock-test.sh |
Tests native-client shutdown sequencing. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| @@ -0,0 +1,3 @@ | |||
| echo "Install the native Omarchy screensaver" | |||
|
|
|||
| omarchy-pkg-add omarchy-screensaver | |||
There was a problem hiding this comment.
Agreed. omacom/omarchy-pkgs#158 is clean and mergeable, and this PR must merge only after that package is published. I also updated the launcher to retain the terminal fallback whenever the native binary is absent; the migration intentionally remains strict so a release-order mistake cannot silently mark the package installation complete.
| omacut | ||
| omawrite | ||
| omarchy-nvim | ||
| omarchy-screensaver |
There was a problem hiding this comment.
Agreed; the package PR is the release prerequisite and is now called out explicitly in the PR description. The launcher also falls back to the existing terminal implementation when the package is absent, but fresh installs must still wait for omacom/omarchy-pkgs#158 to publish the dependency.
|
One QXL data point that may be useful before this becomes the default screensaver path: the currently shipped Foot/ttfx implementation at 120 FPS triggered a complete render-session freeze on an Omarchy 4.0.1 QXL guest. The recorded boot produced 117 The direct Wayland/SHM implementation here should remove substantial terminal overhead, but the native source also defaults to a 120 FPS simulation/presentation path. Could we test it on QXL or retain a supported frame-rate override when the native package is selected? Draft #8556 adds |
|
Revived on today's quattro in #16800, with your screensaver forked to omacom/omarchy-screensaver so it can ship from there (omacom/omarchy-screensaver#1). Thanks @tobi. Your launcher hand-off, lock shutdown and migration carried over. Rebasing and reviewing it needed four more things:
Worker verification and review are in #16800. It stays a draft until the package is published. This one stays open for the maintainer to close in its favour. |
Summary
omarchy-launch-screensaveras the stable entry point and exec the packaged native implementation whenever it is installedomarchy-screensaverpackage from Add omarchy-screensaver omarchy-pkgs#158 for fresh and existing systemsThe preferred implementation is a Rust
wlr-layer-shellclient. It creates one exclusive overlay per output, renders ttfx directly into persistent Wayland SHM buffers, and preserves the existing toggle, force, branding, dismissal, lock-state, cursor, namespace, and multi-monitor contracts. Once the package is installed, the launcher immediatelyexecs the native binary and does not start a terminal.Implementation and v1.0.0 binaries: https://github.com/tobi/omarchy-launch-screensaver/releases/tag/v1.0.0
Package dependency (must merge first): omacom/omarchy-pkgs#158
Verification
test/shell.d/launch-screensaver-test.shtest/shell.d/system-lock-test.sh./test/climakepkg --force --noconfirmand passed its release checksumA prior
./test/allrun completed 178 of 181 shell test files; the remaining failures were in the Fireworks local-midnight fixture, duplicate live-session IPC registration, and a missing omarchy-iso checkout.