Repository navigation
Conversation
Runtime validationValidated SHA
The 20/30 FPS runs used the same screensaver input and deterministic This validates the override as a mitigation on this specific QXL VM, not as a kernel/QXL fix. |
There was a problem hiding this comment.
Pull request overview
Adds a configurable terminal screensaver frame rate while preserving the 120 FPS default and validating supported values.
Tip
If you aren't ready for review, convert to a draft PR.
Click "Convert to draft" or run gh pr ready --undo.
Click "Ready for review" or run gh pr ready to reengage.
Changes:
- Reads and validates
OMARCHY_SCREENSAVER_FRAME_RATE. - Documents the UWSM override.
- Adds shell coverage for default, custom, and invalid values.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
bin/omarchy-screensaver |
Validates and forwards the configured frame rate. |
manual/13-toggles-idle-screensaver.md |
Documents frame-rate configuration. |
test/shell.d/screensaver-test.sh |
Tests frame-rate behavior. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Fixes #8554
Summary
OMARCHY_SCREENSAVER_FRAME_RATEContext
The QXL guest documented in #8554 freezes its Wayland session after the stock 120 FPS Foot/ttfx screensaver starts. The kernel recorded 117 TTM eviction failures, a QXL VRAM allocation failure, and repeated
qxl_fence_waitstalls. Disabling the screensaver prevents the failure, but currently there is no supported middle ground between editing the package-owned script and disabling the feature entirely.This intentionally does not auto-detect QXL or change the default for everyone. It provides a small, reversible mitigation and a controlled way to test a conservative rate such as 20 on constrained displays.
PR #7193 would make the terminal implementation a fallback behind a native Wayland client. That client should preserve the same override if it becomes the default; this draft is limited to the implementation currently shipped by
quattro.Testing
test/shell.d/screensaver-test.shbash -n bin/omarchy-screensaver test/shell.d/screensaver-test.shgit diff --check./test/all:test/clipassed and the new screensaver test passed. The shell suite reported seven unrelated environment/fixture failures that also reproduce at the untouched base commit: missingomarchy-pkgscheckout coverage, two existing command-path/animation tests, a QR fixture mismatch, and restricted writes under the host$HOME.I did not deliberately run the live 120 FPS failure again: recovering this guest requires stopping the graphical session, and #8554 already contains the complete user-journal and kernel timeline. The override path itself is exercised through a pseudo-terminal with stubbed
ttfx,hyprctl, and process cleanup.