Skip to content

Route the Voxtype model picker to the install flow when voxtype is missing - #8631

Closed
alexandru-savinov wants to merge 1 commit into
omacom:quattrofrom
alexandru-savinov:guard-voxtype-model-when-missing
Closed

alexandru-savinov wants to merge 1 commit into
omacom:quattrofrom
alexandru-savinov:guard-voxtype-model-when-missing

Conversation

@alexandru-savinov

Copy link
Copy Markdown

Follow-up to #6832, which guards omarchy-voxtype-config but leaves the sibling command unguarded.

omarchy-voxtype-model opens the model picker unconditionally:

omarchy-launch-floating-terminal-with-presentation "voxtype setup model"

Voxtype is optional, so this is reachable before it is installed — omarchy voxtype model then pops a floating terminal containing nothing but the failure:

bash: line 1: voxtype: command not found

● Done! Press any key to close...

This is the same shape as #6823, and the same remedy: when voxtype is missing, route to the install flow instead, so the command that was meant to configure dictation offers to install it.

That path is easy to reach right now on any non-x86_64 machine, where voxtype-bin cannot install at all (#8530, and the source-build fallback in #8316). I hit it on aarch64 — the manual points users at voxtype setup model for changing models, so a user following the manual on a machine where the installer silently failed lands here.

Notes

Tests

Adds test/shell.d/voxtype-model-test.sh, covering both branches. Presence is stubbed rather than probed so the branch under test doesn't depend on whether the developer's own machine has Voxtype installed. Verified it fails against the unpatched script.

./test/all: test/cli passes; test/shell passes 202/207. The 5 failures (bar-icon-geometry, config, snapper, theme-install-guards, unowned-system-paths) reproduce identically on a clean checkout of quattro on this machine and are unrelated to this change.

Copilot AI balanced review requested due to automatic review settings August 27, 2026 17:01

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Routes the Voxtype model command to installation when Voxtype is unavailable.

Changes:

  • Adds the missing-command guard and preserves shell restart behavior after model selection.
  • Adds tests covering installed and missing Voxtype paths.

Tip

If you aren't ready for review, convert to a draft PR.
Click "Convert to draft" or run gh pr ready --undo.
Click "Ready for review" or run gh pr ready to reengage.

Reviewed changes

Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.

File Description
bin/omarchy-voxtype-model Routes missing Voxtype to its installer.
test/shell.d/voxtype-model-test.sh Tests both command branches.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@alexandru-savinov

Copy link
Copy Markdown
Author

Any chance to push this?

@omarchybot omarchybot added the bug Something isn't working label Sep 27, 2026
@omarchybot omarchybot added the verified Omarchy Triage has verified that this issue is ready for final review label Oct 1, 2026
@omarchybot

Copy link
Copy Markdown
Collaborator

Reviewed and verified at 2f16e17. The fix works and nothing needs changing.

What was checked. I tested on a disposable Omarchy worker that does not have voxtype installed. The real omarchy-voxtype-model and omarchy-cmd-missing ran, and only the terminal launcher, installer and shell restart were stubbed. On quattro, the script opens a terminal showing bash: line 1: voxtype: command not found and then restarts the shell. On this head, it offers omarchy-voxtype-install and does not restart the shell. test/shell.d/voxtype-model-test.sh passes on the head and on the head merged into current quattro. With the fix reverted, it fails on "missing Voxtype routes the model picker to the installer", so the test is not vacuous. ./test/cli passes on the head. Merged into quattro it has one failure, "vscode generated theme references current theme file", and that test fails the same way on quattro alone, so this PR did not cause it. The change is proportionate: one guard in one script, matching the if/else that #6832 uses for omarchy-voxtype-config and that AGENTS.md prefers.

Second opinion. None this run. The configured reviewer (Codex Medium) answered a ping, but its daily review budget was already spent, so this review is one model's (Claude Opus 5.5).

Related. #13807 also guards omarchy-voxtype-model, along with omarchy-voxtype-config. That overlaps with #6832, and both add test/shell.d/voxtype-config-test.sh, so the two conflict. Its guard ends one branch with exit 0, which AGENTS.md asks contributors to avoid. For the model command, this PR is the earlier fix, the one written in house style, and the one that does not collide with #6832. #6832 and this PR touch different files and can both land. No open issue covers the model command specifically: #6823 is about the bar icon, which runs the config command.

Next. This waits on the maintainer, who will choose between this PR and #13807. It also still needs a second opinion before it can be marked ready.

@ryanrhughes

Copy link
Copy Markdown
Collaborator

Closing this one along with #6832; #14552 replaced omarchy-voxtype-install with omarchy-install-dictation-voxtype, so this guard would now open a terminal on "command not found". Installing Voxtype goes through Setup > Defaults > Dictation now. Thanks for catching the sibling command!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working verified Omarchy Triage has verified that this issue is ready for final review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants