Repository navigation
Conversation
Clicking the bar's Dictation indicator runs omarchy-voxtype-config, which launched `voxtype configure` in a floating terminal even when voxtype was never installed, surfacing a raw `command not found` error. Guard the config command so a missing voxtype routes to omarchy-voxtype-install instead, matching the menu's install.ai.dictation action. Fixes #6823 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
AGENTS.md asks for a full if/else for two-path control flow rather than an exec in one branch that makes the rest unreachable. The missing branch still skips omarchy-restart-shell, since the installer restarts the shell itself once voxtype is in place. The test stubs the presence check, so it passes or fails on the script rather than on whether the machine running it has voxtype installed. It fails on quattro, where a missing voxtype still runs voxtype configure and restarts the shell.
|
Reviewed, reproduced and verified on a worker built from the Omarchy ISO, with voxtype not installed. Reproduction. On Pushed to this branch (dc9d15e):
Suite. Competing fix. #6932 fixes the same click in a different way: a new Second opinion. Codex Medium was asked to choose between this PR and #6932 without being given an answer, and chose this one for the reasons above. Its review of the final diff found no defects, and it confirmed that the test tells the two scripts apart. It can read this session's working files, so its agreement is not guaranteed to be independent. Waiting on CI, which has not reported on dc9d15e yet (CodeQL ran on the previous head), and then on the maintainer. |
|
Closing this one out; #14552 removed the bar's Dictation indicator, so nothing clicks through to |
Fixes #6823
Clicking the bar's Dictation indicator runs
omarchy-voxtype-configunconditionally. On systems where voxtype was never installed, that opened a floating terminal that died withbash: voxtype: command not found.The status side already degrades gracefully —
omarchy-voxtype-statusguards withomarchy-cmd-missing voxtypeand emits an idle payload — but the click path had no equivalent guard. This adds one in the same place, shell-side: when voxtype is missing,omarchy-voxtype-confignow execs the floating-terminal install flow (omarchy-voxtype-install), the same action as the menu'sinstall.ai.dictationentry. The QML stays free of policy, and every caller of the config command is covered at once.The install script already reloads Hyprland and restarts the shell on completion, so the bar indicator comes alive without any extra plumbing.
— 🤖 Claude, posting on behalf of @dhh