Skip to content

Route dictation config to the install flow when voxtype is missing - #6832

Closed
dhh wants to merge 2 commits into
quattrofrom
voxtype-config-install-guard
Closed

dhh wants to merge 2 commits into
quattrofrom
voxtype-config-install-guard

Conversation

@dhh

@dhh dhh commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

Fixes #6823

Clicking the bar's Dictation indicator runs omarchy-voxtype-config unconditionally. On systems where voxtype was never installed, that opened a floating terminal that died with bash: voxtype: command not found.

The status side already degrades gracefully — omarchy-voxtype-status guards with omarchy-cmd-missing voxtype and emits an idle payload — but the click path had no equivalent guard. This adds one in the same place, shell-side: when voxtype is missing, omarchy-voxtype-config now execs the floating-terminal install flow (omarchy-voxtype-install), the same action as the menu's install.ai.dictation entry. The QML stays free of policy, and every caller of the config command is covered at once.

The install script already reloads Hyprland and restarts the shell on completion, so the bar indicator comes alive without any extra plumbing.

— 🤖 Claude, posting on behalf of @dhh

Clicking the bar's Dictation indicator runs omarchy-voxtype-config, which
launched `voxtype configure` in a floating terminal even when voxtype was
never installed, surfacing a raw `command not found` error. Guard the
config command so a missing voxtype routes to omarchy-voxtype-install
instead, matching the menu's install.ai.dictation action.

Fixes #6823

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Copilot AI balanced review requested due to automatic review settings August 13, 2026 20:34

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.


💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

AGENTS.md asks for a full if/else for two-path control flow rather than an exec in one branch that makes the rest unreachable. The missing branch still skips omarchy-restart-shell, since the installer restarts the shell itself once voxtype is in place.

The test stubs the presence check, so it passes or fails on the script rather than on whether the machine running it has voxtype installed. It fails on quattro, where a missing voxtype still runs voxtype configure and restarts the shell.
@omarchybot omarchybot added the verified Omarchy Triage has verified that this issue is ready for final review label Sep 28, 2026
@omarchybot

Copy link
Copy Markdown
Collaborator

Reviewed, reproduced and verified on a worker built from the Omarchy ISO, with voxtype not installed.

Reproduction. On quattro, running omarchy-voxtype-config in the worker's Hyprland session launched a floating terminal on voxtype configure and then restarted omarchy-shell ("Exiting due to IPC request" in the journal), which is the click-then-shell-restart sequence #6823 describes. At this head the same command opens the Omarchy terminal on omarchy-voxtype-install, showing the "Install Voxtype + AI model (~150MB) to enable dictation?" prompt, and the shell is not restarted.

Pushed to this branch (dc9d15e):

  • The guard is now a full if/else instead of an exec in one branch, per the control-flow rule in AGENTS.md. Behaviour is unchanged: the missing-voxtype branch still skips omarchy-restart-shell, because the installer restarts the shell itself once voxtype is in place.
  • test/shell.d/voxtype-config-test.sh stubs the presence check and asserts both branches: missing routes to the installer without configure or restart, and present runs configure and restarts without the installer. On the worker it fails against quattro's script and passes against this branch.

Suite. ./test/all on the worker, at this head, has one failure (headless theme set creates current background symlink), which also fails on the merge base without this change. With the change applied to current quattro, the failures are the same six that plain quattro has. screenshot-sanity-test.sh failed once in that run and passed 3 of 3 when rerun alone.

Competing fix. #6932 fixes the same click in a different way: a new omarchy-voxtype-open-config wrapper, called from the QML, plus an upgrade-invitation migration. That leaves omarchy-voxtype-config itself, and omarchy voxtype config, unguarded, bundles a separate onboarding change, and currently conflicts with quattro. This PR guards the command every caller goes through. #8631 applies the same guard to omarchy-voxtype-model and complements this PR rather than competing with it.

Second opinion. Codex Medium was asked to choose between this PR and #6932 without being given an answer, and chose this one for the reasons above. Its review of the final diff found no defects, and it confirmed that the test tells the two scripts apart. It can read this session's working files, so its agreement is not guaranteed to be independent.

Waiting on CI, which has not reported on dc9d15e yet (CodeQL ran on the previous head), and then on the maintainer.

@ryanrhughes

Copy link
Copy Markdown
Collaborator

Closing this one out; #14552 removed the bar's Dictation indicator, so nothing clicks through to omarchy-voxtype-config anymore. It also replaced omarchy-voxtype-install with omarchy-install-dictation-voxtype, so this guard would now open a terminal on "command not found". Thanks for chasing it down!

@emirb emirb removed this from the 4.5 milestone Nov 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working verified Omarchy Triage has verified that this issue is ready for final review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dictation bar icon errors when voxtype isn't installed (missing guard in click handler)

5 participants