Repository navigation
Conversation
The four bin/omarchy-install-service-{dropbox,nordvpn,once,tailscale} scripts install packages via omarchy-pkg-add, enable systemd units, and set up user-level services. None of them declares errexit, so a failure in any step is silently swallowed and the script moves on. A bar entry can end up enabled for a service that never installed.
The install/hardware/* scripts don't have this problem because they go through run_logged, a bash -eE wrapper. These bin/ entries are exec'd directly by bin/omarchy, with no error wrapper around them.
Each script gets a set -e line directly under its existing metadata header, the same pattern sibling scripts in bin/ already use.
|
Reviewed at 81cc815 against What was checked. On a disposable Omarchy worker VM, each of the four installers was run with Does Second opinion. None. The configured reviewer (Codex Medium) answers, but omabot's daily review budget was used up, so this review is one model's reasoning (Claude Opus 5.5), not two. Related. #13533 rewrites What happens next. This is labelled |
Service install scripts fail silently
bin/omarchy-install-service-{dropbox,nordvpn,once,tailscale} don't declare errexit. omarchy-pkg-add failures get swallowed and the script proceeds to enable systemd units and wire up bar entries that lead to nothing.
Related: #9123.