Repository navigation
Add SiteConfigStatus (interfaces#27) - #28
skunal3318 wants to merge 3 commits into
Conversation
panthera-momagdii
left a comment
There was a problem hiding this comment.
Reviewed 1f46b295ccfc99901072a263769c97adf87e18c5 against 87ab8a936c97ab55ee74b8988ca3d7659160ea6a.
The interface change is sound: SiteConfigStatus is registered, the added field bumps NavigationStatus to contract version 2, the compatibility snapshot is regenerated, and the installed C++ and DDS consumer checks exercise the nested field. The state/coverage distinction and the separate required/optional coverage reasons agree with the latest clarification on #27.
The Jazzy verification job passes. Its existing deliberate-revert check is retained; that particular fixture removes thresholds_id, so it should not be described as a site_config-specific revert run.
Source approval only: the DCO check is still action_required because this commit lacks the author's sign-off. Please correct that with your own identity before merge and let the checks rerun. This approval does not waive DCO or establish completion of N2.
I am reviewing platform-sw#73 separately. Its producer must honor these content-hash definitions and missing-input rules; the producer's current limitations are not accepted by this interface approval.
ChatGPT-assisted source and hosted-evidence review. No local ROS or simulation run.
Closes #27.
Adds
SiteConfigStatus, bumpsCONTRACT_VERSION1->2, updatesCONTRACT.md's versioning note and field-validity table, and extends the consumer tests (consumer.cpp,navigation_exchange.py) to exercise the new field.Verified with
tools/verify.shend-to-end: build, lint/schema, generated-interface checks, compatibility snapshot regen (compatibility/jazzy.json), clean consumer build, and the dual-RMW navigation-message-exchange test including the deliberate-revert rejection check — all PASS.