Repository navigation
chore(lint): pin tomlkit to avoid pysen dumper failure - #242
Closed
ryuyamamoto-pfr wants to merge 1 commit into
Closed
ryuyamamoto-pfr wants to merge 1 commit into
ryuyamamoto-pfr wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
概要
lint CI が次のエラーで失敗する状態を直します。
tools/lint/requirements.txtは pysen を pin していますが、その推移的依存であるtomlkitは pin していないため、CI は常に最新版を取得します。tomlkit0.15.1 は改行を含むコメントを拒否するようになり、pysen 0.10.4 が設定ファイル出力時に渡す 2 行のコメントで例外になります。lint workflow の直近の成功は 2026-07-09 で、その後のリリースで壊れたものです。変更内容とは無関係に、mainおよびすべての PR で発生します。この PR は #240 / #241 とは独立しており、
mainに入れば両 PR の CI も再実行で通ります。変更内容
tomlkitを明示的に追加し、pysen が動作するバージョンに固定しました。検証
0.15.1 では CI と同じ
Comment cannot contain line breaksで中断し、0.15.0 では pysen が設定ファイルの出力を終えて各 linter の実行まで進みます。PRチェーン