Keep rebuilt evidence consistent with current curation - #429
Merged
Conversation
Coverage Report for CI Build 34052097524Coverage increased (+0.07%) to 83.086%Details
Uncovered ChangesNo uncovered changes found. Coverage Regressions160 previously-covered lines in 2 files lost coverage.
Coverage Stats
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changing study curation could leave observations and binding indexes marked current, and clearing the classification cache could still reuse an inner stale cache. Normal builds now fingerprint the curation YAMLs, cell-line registry, and referenced peptide-attribution CSVs, then refresh the file-backed and derived caches before rebuilding. Older metadata without the new input fingerprints rebuilds once.
Removed four redundant unbounded cache wrappers so the existing bounded caches own eviction and clearing. Version: 1.58.1.
Validation: format and lint pass;
./test.shpasses 1,205 tests. Seven regressions cover same-size/timestamp-preserving curation edits, newly referenced attribution files, and consecutive normal builds that persist changed restriction evidence and cancer/healthy classification. The focused builder/curation/smoke run also passed 290 tests.Closes #424.
Closes #428.