Conversation
Select held at the moment the pad dropped kept its held_since across the disconnect: back three seconds later with Select still down, the first tick called it a two-second hold and shut the robot down. D-pad up had the same shape — a mode switch nobody asked for. A hold was measured against the pad that left; the next pad's buttons start from nothing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Select held at the moment the pad dropped kept its
held_sinceacross the disconnect: the pad back three seconds later with Select still down, the first tick called it a two-second hold and shut the robot down. D-pad up had the same shape — a mode switch nobody asked for.A hold was measured against the pad that left; the next pad's buttons start from nothing. The no-pad branch now resets the Select state machine and the D-pad-up hold alongside the IMU-head state it already reset.
Regression test pins both directions: a reset hold across a >2 s dropout is not a shutdown, and without the reset the same tick arithmetic is — which is why the reset exists.
cargo test -p padd,clippy -D warnings,fmt --checkall green.