padd: an unreadable sibling does not end the IMU search - #274
Merged
pierre-rouanet merged 1 commit intoSep 14, 2026
Conversation
A candidate whose properties read fails — unplugged between the read_dir and the read, so the file is gone — returned None for the whole search, and the real IMU sorting after it was never seen: no IMU head control and a frozen monitor panel for the rest of that pad's session. Skip it and keep walking.
pierre-rouanet
approved these changes
Sep 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
imu_siblingwalks the event nodes under the pad's HID parent looking for the one with the accelerometer property. One candidate whosedevice/propertiescannot be read — the device was unplugged between theread_dirand the read — returnedNonefor the whole search, and the real IMU sorting after it was never seen: no IMU head control and no monitor panel for the rest of that pad's session.Skip the vanished candidate and keep walking. Regression test lays out the sysfs tree with a dead sibling between the pad and its IMU.
cargo test -p padd,clippy -D warnings,fmt --checkall green.