robotctl: the IMU panel goes away with a pad swap or a lost tap - #275
Open
hadelan wants to merge 1 commit into
Open
robotctl: the IMU panel goes away with a pad swap or a lost tap#275hadelan wants to merge 1 commit into
hadelan wants to merge 1 commit into
Conversation
Two paths no ImuDetached covers left the last pad's IMU panel frozen on screen forever: a pad swap with the tap alive (the new pad has no IMU, so no ImuAttached ever follows the Attached), and the tap connection itself dropping (the ImuDetached died with it, and the next subscription seeds only what the new padd has). Attached now clears the panel until the new pad's own ImuAttached, and PadLost clears it with the pad.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two paths no
ImuDetachedcovers left the last pad's IMU panel frozen on screen forever, drawn as if live:ImuAttachedever follows itsAttached— andAttacheddid not clear the panel.ImuDetacheddied with the connection, and the next subscription seeds only what the newpaddhas.PadLostcleared the device but not the IMU.Attachednow clears the panel until the new pad's ownImuAttached, andPadLostclears it with the pad. Regression test walks both paths.cargo test -p robotctl,clippy -D warnings,fmt --checkall green.