tof: back off before reopening the head IMU after a read failure - #276
Open
hadelan wants to merge 1 commit into
Open
tof: back off before reopening the head IMU after a read failure#276hadelan wants to merge 1 commit into
hadelan wants to merge 1 commit into
Conversation
A read failure fell straight back into open_imu: a chip that answers its ID but cannot stream was reopened in a tight loop, warning each time, on the bus the audio codec shares. Same backoff as the open-failure path, which the module docs always claimed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A read failure in the BMI088 loop fell straight back into
open_imu: a chip that answers its ID but cannot stream was reopened in a tight loop, warning each time, on the I²C bus the audio codec shares. The open-failure path has always backed off; the read-failure path now waits on the same backoff, which is what the module docs already claimed.No new arithmetic — the retry sequence is the one the open-failure path and the ToF loop already use — so no new unit test; the loop itself needs the chip.
cargo test -p tof,clippy -D warnings,fmt --checkall green.