padd: only the driving pad's buttons may act - #277
Open
hadelan wants to merge 1 commit into
Open
Conversation
With two pads connected, the event drain matched no pad id: a Start or Select from the second pad toggled the policy or shut the robot down while the sticks it combined with were the first pad's. The driving pad is the first one; events from any other are skipped, and after the drain the pad is re-read by id — a Disconnected dequeued this tick must yield one tick of "pad gone", not a silent handover to the other pad's sticks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With two pads connected, the event drain matched no pad id: a Start or Select from the second pad toggled the policy or shut the robot down, while the sticks those commands combined with were the first pad's.
The driving pad is the first one; events from any other are skipped. After the drain the pad is re-read by id (
connected_gamepad), so aDisconnecteddequeued this tick yields one tick of "pad gone" instead of silently handing the robot the other pad's sticks.Behavior with a single pad is unchanged. The drain needs a real
gilrsinstance, so there is no new unit test;cargo test -p padd,clippy -D warnings,fmt --checkall green.