Repository navigation
Notifications: SCN, incidents and the (simulated) FedRAMP Security Inbox - #508
Merged
Merged
Conversation
…notifications and deadline checks Every change now carries an explicit significant-change evaluation (SCN-Type, SCN-Rationale, and SCN-Record for adaptive/transformative/emergency); a missing tag fails instead of defaulting to routine-recurring, and class-change blocks. The deploy appends every merged evaluation to a signed, append-only log and publishes every register row in FedRAMP's SCN schema with a Markdown view and an Atom feed, listed in the CPO. Business-day deadlines (US federal holidays) are read from the vendored rules; a scheduled workflow fails on anything overdue. Notification is publication only; nothing is sent. SCN-Type: not-significant SCN-Rationale: change-management process and compliance reporting only; no component, boundary, data flow or access change to the system. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ard) SCN-Type: not-significant SCN-Rationale: input validation in the new SCN log builder; no system component, boundary or access change. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…torical notices The record describes the system after a successful deploy of this commit: the deploy builds and publishes every notice (any failure fails the deploy; the round-trip check compares the served index and feed), so the mechanism is in force. SCN-2026-001..005 were published after their deadlines and are named. SCN-Type: not-significant SCN-Rationale: rule-record text and a test only; no component, boundary, data flow or access change. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…/NRI triggers - data/incidents.json + schema + fail-closed loader (scripts/_incidents.py): every incident carries its FedRAMP reportability evaluation and reason; default N5 until an IEC-CSO-EFI estimate (checked against the rule's rubric). - scripts/build-incident-report.py renders Initial/Ongoing/Final reports in FedRAMP's incident report schema (validated before write) and the incident log; Class C clocks and the rating scale are read from the pinned rules. - policies/triage.rego incident_triggers: VER-TFR-IRI and VER-TFR-NRI, with thresholds parsed from the rule text (fail closed on a changed text). - Reconciliation invariant (m): an open incident's findings are in the VDR. - incident-reports.yml publishes unattended (publish-only; nothing is sent); bootstrap role scoped to .well-known/incident-*; the deploy also publishes; watchdog metric and alarm for overdue reports; freshness entry. - Dated exercise (2026-11-05, exercise: true): IIR -> 2x OIR -> FIR, plus a not-reportable evaluation; run end to end in tests. - FRR records: EFR, DPR, EFI, VER-TFR-IRI, VER-TFR-NRI Implemented; IIR, OIR, FIR, AIR Partially Implemented (publish-only; bootstrap apply pending). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…s state the deployed system The deploy fails before applying anything unless AWS_INCIDENT_REPORTS_ROLE_ARN names the bootstrap incident-reports role and the incident-reports environment deploys only from main (scripts/check-incident-publisher.py; known-bad fixture with the variable missing). After the deploy job, the deploy calls incident-reports.yml (now also workflow_call) on its own role, passing only the CloudFront secret, so a green deploy proves the publisher publishes. IEC-CSO-IIR/OIR/FIR/AIR gaps now state only what holds after a successful deploy: published, not delivered to FedRAMP or agencies, by the operator's decision. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The inbox is simulated for this proof of concept by the operator's decision:
nothing is received or sent. scripts/_fsi.py is the inbox logic
(classification, designators, Class C deadline, register, header-safe
acknowledgement sent once, paging). Every deploy runs it over committed
synthetic messages before the SDR build, fails on any unexpected outcome, and
publishes the signed, dated result as fedramp-inbox-simulation.json, labelled
as a simulation. The published contact says so and points to LinkedIn; the
AFC-CSO-NOC check applies to that contact. AFC records are Implemented with
simulated {counterparty: mail}.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…e SDR
Every deploy and every unattended publish now "delivers" each incident report
the log lists to a simulated FedRAMP and agency recipient
(scripts/deliver-incident-reports.py): read back, checked against the
published sha256 and FedRAMP's schema, and recorded in the signed delivery log
/.well-known/incident-deliveries.json. Nothing is sent. A failed delivery
stops publication.
The deploy job assumes the incident publisher's role before it builds the SDR
(scripts/check-incident-role.py), so a deploy whose publisher role does not
work stops before publishing records that claim it. The role's trust gains the
reviewer-gated deploy environment (bootstrap apply).
IEC-CSO-IIR/OIR/FIR/AIR are Implemented with simulated {incident-recipient}.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Nov 5, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SCN-Type: not-significant
SCN-Rationale: PROVISIONAL, Sam to confirm the type: notification processes, simulated counterparties and a scoped incident-reporting IAM role and workflow; no change to the system's components, boundary or data flows otherwise.
This PR consolidates #504 (SCN), #506 (incident reports) and #507 (FedRAMP Security Inbox) into one notifications PR. It also finishes the incident rules against simulated recipients.
Changed
SCN (from #504, unchanged)
scripts/scn-evaluate.pyandscripts/_scn.py, run byscn-tag.yml. Every PR body, or direct-push commit, carriesSCN-Type:andSCN-Rationale:. Adaptive, transformative and emergency changes also carrySCN-Record:.class-changealways fails, and transformative plan lead times are enforced./.well-known/scn-evaluations.jsonis append-only against the previously published copy.significant-change-notifications.jsonwith an Atom feed. They are never pruned, and each carries its deadlines. Deadlines are computed in business days, excluding federal holidays (scripts/_bizdays.py).scn-deadlines.ymlcheck raises an issue when a notice is overdue.Incident reports (from #506)
data/incidents.json, with a fail-closed loader. The IEC-CSO-EFR evaluation, the IEC-CSO-EFI/DPR rating, and the Initial, Ongoing and Final reports in FedRAMP's incident report schema all come from it. Class C clocks are read from the pinned rules.policies/triage.rego. Reconciliation invariant (m) is added.incident-reports.ymlruns on a bootstrap role scoped to.well-known/incident-*. It also runs after each deploy (jobincident-publisher).IncidentReportsOverdue.exercise: true.Incident reports: new in this PR
scripts/deliver-incident-reports.pyruns on every deploy, inside "Build incident reports", before signing and before the SDR. It also runs in every unattended publish, as the step "Deliver incident reports (simulated recipients; nothing sent)"./.well-known/incident-deliveries.json. It is labelled as a simulation and showsmessages_actually_sent: 0.tests/fixtures/incidents/delivery-*.json.scripts/check-incident-role.py), runs before the SDR build.AssumeRoleWithWebIdentityforAWS_INCIDENT_REPORTS_ROLE_ARN.github-actions-incident-reports-oidc, then discards the credentials.tests/fixtures/incidents/sts-*.xml.incident-publisherjob after the deploy stays as a second proof.environment:${var.deploy_environment}), so the deploy job can assume the role. This adds no privilege beyond what the deploy role already has: the incident role's permissions are only PutObject on.well-known/incident-*and one CDN invalidation.FedRAMP Security Inbox (from #507, reworked: simulated)
scripts/_fsi.pyis the inbox logic, written as pure functions:data/fsi-simulation/messages.json): Emergency Test, Important with an injection attempt, general, forged @gsa.gov, auto-reply, bulk, bounce, envelope-only, a non-designated Emergency sender, a look-alike domain, a display-name spoof, and a failed first send./.well-known/fedramp-inbox-simulation.json, labelled as a simulation, with sender domains only. The file has a freshness entry and is covered by the redaction gate, the publish step and the round-trip check.tests/fixtures/fsi/simulation-wrong-expectation.json.data/cds/offering.json(fedramp_security_inbox.contact, published in the CPO) reads: "Simulated for this proof of concept: there is no FedRAMP Security Inbox, no mail is received or sent, and the inbox is permanently at zero because it does not exist. Hit me up on LinkedIn: https://www.linkedin.com/in/sa2/".contactEmailmust be an email address, and the schema has noproviderExtensions.build-cpo.pypublishes its owncertification_datashape. The statement goes there and is never put in an email field.scripts/check-fsi-notice.pyruns in the unit-test job. A change to the contact must append a history entry with a datedfedramp_notifiedmarker.Shared
simulated({mail} × 7, {incident-recipient} × 4) and deploy-time evidence.tests/test_frr_records.py, two tests no longer assume that the committed register has nosimulatedrecords. Their checks are unchanged.docs/runbooks/fedramp-security-inbox.md(rewritten)docs/incident-response.mddocs/policies/ir-policy.mddocs/cr26-applicability.md(AFC and IEC are no longer listed N/A)Effect
After deploy, the live site publishes:
fedramp-inbox-simulation.jsonandincident-deliveries.json(both simulations, both signed);Every deploy fails before the SDR is built if any of the following fails: the inbox simulation, the incident delivery, or the incident role assumption.
Records (
python3 scripts/_frr.py, 154 rules):Simulated: mail 7, incident-recipient 4.
33 records flip to Implemented:
--completestill lists 102 open records, none of them AFC, SCN or IEC. They belong to the other workstreams.Verified
make checkpasses: ruff, mypy, 1208 tests, and OPA 49/49.infrastructure/policy),check-policy-annotations,check-exceptions,check-wasm-safeandcheck-fsi-notice.Residual
incident-publisherjob after the deploy.Needs human
not-significantis proposed. The change adds a scoped IAM role, an unattended publishing workflow and a deploy dependency on them, so Sam may treat it as adaptive.infrastructure/bootstrap/incident-reports.tf(now including the deploy-environment trust) from a tree synced to main.AWS_INCIDENT_REPORTS_ROLE_ARNfrom theincident_reports_role_arnoutput.incident-reports: no reviewer; deployment branches custom, exactlymain.scn-tagfails.simulated.incident-publisherjob as a second proof.decided_by: Operator.reconcile.mmode (block).Couldn't verify
scripts/build-conformance.pyfails locally on a missing junit.xml, and also fails on the base.🤖 Generated with Claude Code