Repository navigation
docs: map entire AR product redesign (architecture-preserving) - #245
scrimshawlife-ctrl wants to merge 3 commits into
Conversation
Add master redesign map, system inventory, and phased plan for AR-designed Waykin (no longer audio-first identity). Supporting docs only — binding law unchanged until Phase 0. Wire indexes and freeze/continuation pointers.
Add AR_SESSION_IA_CONFLICTS.md covering shipped 2D-root session vs AR-designed target, exclusive Lira, dual covers, a11y, fallback, and authority deadlock. Wire into redesign map, plan, and indexes.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1acba19c5d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| Product direction (planning): **AR-designed** session surface; no longer audio-first identity. | ||
|
|
||
| - [AR_PRODUCT_REDESIGN_MAP.md](AR_PRODUCT_REDESIGN_MAP.md) — full map and freeze rings |
There was a problem hiding this comment.
Remove trailing whitespace so required validation passes
On this commit, git diff 967a43f^ 967a43f --check reports trailing-whitespace errors here and on numerous lines in docs/plans/AR_APP_REDESIGN_PLAN.md, so the repository's required git diff --check gate cannot pass. Remove the trailing spaces, using Markdown constructs that do not depend on them where line breaks are needed.
AGENTS.md reference: AGENTS.md:L47-L54
Useful? React with 👍 / 👎.
| | ----- | ----- | | ||
| | OBSERVED | AR command spine, freeze, optional fullScreenCover entry, audio-first binding language | | ||
| | INFERRED | Product feels multi-modal; audio-first under-describes ship | | ||
| | SPECULATIVE | Session-default AR will increase return intent (needs outdoor proof) | |
There was a problem hiding this comment.
Replace the unsupported SPECULATIVE evidence label
This claim table introduces SPECULATIVE, but the repository contract permits only OBSERVED, INFERRED, and NOT_COMPUTABLE. Since the claimed effect on return intent lacks evidence, classify it as NOT_COMPUTABLE rather than adding a fourth vocabulary value that downstream evidence reviews will not recognize.
AGENTS.md reference: AGENTS.md:L31-L37
Useful? React with 👍 / 👎.
| | Rule | Detail | | ||
| | ---- | ------ | | ||
| | Default | World-plane plant (ground raycast → `AnchorEntity`) | | ||
| | Fallback | Camera-anchor if raycast fails | |
There was a problem hiding this comment.
Document the assumed-ground placement fallback
When a ground raycast fails, the reviewed implementation does not immediately use a camera anchor: ARPlacementResolver.placeCompanion first calls placeOnAssumedGround and reaches placeOnCamera only if that also fails. Describing camera anchoring as the direct fallback makes the new redesign map and inventory omit a shipped continuity stage, which can cause Phase 1 coverage or later placement work to overlook the assumed-floor behavior.
Useful? React with 👍 / 👎.
Capture long-term AR companion platform intent (walks/runs/rides, fitness, worldbuilding, user-designed companions/experiences) as REFERENCE_ONLY, with gated R0–R8 ladder. Wire into redesign map, roadmap, and indexes without changing binding MVP law.
|
Safety hold after |
prabu-openclaw
left a comment
There was a problem hiding this comment.
Approving. Docs only — the two non-docs/ files are README.md and ROADMAP.md, both pointer wiring.
The governance is what makes this safe to land despite its size: does_not_override: [SOLO_MVP_SCOPE, WAYKIN_SPEC], the north star marked REFERENCE_ONLY, and R0 explicitly labelled as current binding law. So the AR-first direction is documented as intent without silently displacing the audio-first contract still in WAYKIN_SPEC.
Worth naming that tension so it is a deliberate decision rather than a drift: the spec's opening line is still "audio-first adaptive walking experience", and this maps a product where AR is the primary session surface. The conflict register (C1–C11) is the right place for it, and Phase 0 is the right time to resolve it — flagging only so the spec edit is conscious when it comes.
One observation from device work that may be useful input to the plan: audio is currently the most reliable layer (.playback + background mode, cues confirmed audible on walks), while AR is the layer that has needed the most repair. Not an argument against the direction — just that "audio-first" is presently the part that works.
Superseded by recovery on freeze mainPer safety hold (post-#246/#248) and freeze plan Workstream E: do not merge this stale branch history. Recovery PR: #251 (
Please review/approve #251, then close this PR as superseded. |
…ver-245 docs: recover AR redesign docs onto freeze main (supersedes #245)
Summary
Documents the entire AR product redesign for Waykin as supporting design/plan material. Operator direction: no longer audio-first; design for AR as the primary session surface, while movement remains gameplay authority and the existing
ARWorldCommandadapter spine is preserved.No Swift / Core / app behavior changes in this PR — docs and index wiring only. Binding product law (
SOLO_MVP_SCOPE,WAYKIN_SPEC) is intentionally unchanged until Phase 0.Also captures the long-term north star (multi-activity AR companion + fitness + worldbuilding + user-designed companions/experiences) as REFERENCE_ONLY, with a gated MVP → vision ladder (R0–R8) so it is not confused with the walk-only MVP.
1acba193121bf7PR: #245
Branch:
docs/ar-product-redesign-map→mainImplementation details
What this PR implements (documentation system)
New files
docs/design/AR_PRODUCT_REDESIGN_MAP.mdWAYKIN-AR-PRODUCT-REDESIGN-MAP-001v1.0)docs/design/AR_SYSTEM_INVENTORY.mdWAYKIN-AR-SYSTEM-INVENTORY-001v1.0)docs/design/AR_SESSION_IA_CONFLICTS.mdWAYKIN-AR-SESSION-IA-CONFLICTS-001v1.0)docs/plans/AR_APP_REDESIGN_PLAN.mdWAYKIN-AR-APP-REDESIGN-PLAN-001v1.0)docs/design/PRODUCT_VISION_NORTH_STAR.mddocs/canonical/MVP_TO_VISION_LADDER.mdModified files (wiring only)
README.mddocs/README.mddocs/design/README.mddocs/plans/README.mddocs/design/AR_MVP_FREEZE.mdApp/AR/**featuresdocs/design/CONTINUATION_PLAN.mdArchitecture preserved (explicit non-implementation)
These docs encode and must not be violated by later implementation PRs:
WaykinCorefree of ARKit/RealityKit/MapKit/filenamesARWorldCommand/SpatialIntentNorth star vs near-term (operator intent)
PRODUCT_VISION_NORTH_STAR.mdMVP_TO_VISION_LADDER.mdNot claimed as current product law: multi-sport, marketplace, multi-companion, or creator tools. Those remain excluded/deferred in binding docs until ladder promotion.
Redesign envelope (how future work is allowed)
Phased plan (documented, not executed here)
SOLO_MVP_SCOPE,WAYKIN_SPEC, UIUX B1–B4, skillsREPO_CONTEXTSession IA conflicts captured (C1–C11)
Full text:
docs/design/AR_SESSION_IA_CONFLICTS.mdTarget IA sketch (docs only): AR stage when capability allows; 2D fallback; audio supporting; map peek under AR not peer cover; 2D Lira figure suppressed while AR owns companion.
Document authority note
Per
docs/governance/DOCUMENT_AUTHORITY.md:SOLO_MVP_SCOPE/WAYKIN_SPEC/ UIUX product surfaces until Phase 0 promotes binding language.Explicitly out of scope (this PR)
WaykinAppbehavior changeApp/AR/**featuresDiff stats
Test plan
Sources/,App/, or test code changesdocs/README, design README, plans README)App/AR/**feature expansionActiveSessionView+ UIUX B1–B6Rollout