Repository navigation
fix(bundles): reject a non-string skills.sh schema field - #3
Draft
vchamarthi wants to merge 2 commits into
Draft
vchamarthi wants to merge 2 commits into
vchamarthi wants to merge 2 commits into
Conversation
The check fails on current main: $schema 1 and schema ["not-a-uri"] are accepted.
skills.sh types $schema and schema as string. A number or a list used to exit 0.
This was referenced Oct 22, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tools/validate_skills.pysaysskills.sh.jsonfollows the skills.sh schema, then type-checksnotGroupedand the bundle fields. It did not type-check$schemaorschema. The published schema types both as string. A number or a list still exited 0.Change
A present non-string value is now a FAIL. Absence is still allowed. A string is still allowed.
format: uriis not asserted.Evidence
d1202320f3938afc93982eed1a530e5236a9f985(fork main; tree matches intel/skills6e609e2dcc95af8047aab0f14d6bc688e2034906)python3 tools/validate_skills.py --self-testFAIL --self-test: non-string $schema was accepted; non-string schema was accepted. The same file with"$schema": 1and"schema": ["not-a-uri"]madepython3 tools/validate_skills.pyexit 0.PASS --self-test: non-string skills.sh schema fields are rejected. The mutated file then exited 1 withFAIL skills.sh.json: $schema must be a string, got intandFAIL skills.sh.json: schema must be a string, got list. The live file still exited 0.schema must be a stringcheck.Blast radius
The change is
tools/validate_skills.pyonly. No skill body changes. The liveskills.sh.jsonstill passes. A number or a list in$schemaorschemafails the validator. URI format is not checked.Created with Grok.