feat: implement `keyring_createAccounts` by gantunesr · Pull Request #601 · MetaMask/snap-bitcoin-wallet

gantunesr · 2026-04-28T02:27:58Z

Explanation

Batch account creation via keyring_createAccounts.

What changed

Added AccountUseCases.createMany, which accepts a list of account creation requests and handles the batch as a single operation.
Added repository batch APIs:
- getByDerivationPaths
- insertMany
Updated BdkAccountRepository so batch account creation can:
- read the derivationPaths namespace once,
- read the accounts namespace once,
- create only the missing accounts,
- persist all new accounts with one accounts write,
- persist all derivation path mappings with one derivationPaths write.
Updated KeyringHandler.createAccounts to call createMany once instead of invoking AccountUseCases.create once per account.
Removed the added performance console.log.
Added validation so batch index ranges must use non-negative safe integers.
Added a small mutation queue around account create/delete state mutations to avoid interleaved account state writes from overlapping requests.

References

Note

Medium Risk
Adds a new keyring RPC for batch account creation and changes account persistence/read paths to support bulk operations and cached metadata, which could affect state consistency and account loading behavior.

Overview
Implements the keyring_createAccounts RPC, adding KeyringHandler.createAccounts to validate index ranges, enforce P2WPKH-only v1 constraints, trace batch creation, and internally split large requests into 100-account chunks.

Adds AccountUseCases.createMany plus repository batch APIs (getByDerivationPaths, insertMany) to reuse existing accounts, dedupe duplicate derivation paths, limit creation concurrency, and bulk-persist new accounts with fewer state reads/writes.

Extends persisted AccountState with optional cached metadata and introduces StoredAccountAdapter so lookups can return KeyringAccount-relevant fields without loading full BDK wallets; also bumps @metamask/keyring-api/keyring-snap-sdk to the versions that include the new RPC structs.

^{Reviewed by Cursor Bugbot for commit 947d0ea. Bugbot is set up for automated code reviews on this repo. Configure here.}

- Route KeyringRpcMethod.CreateAccounts and validate with CreateAccountsRequestStruct - Support Bip44DeriveIndex and Bip44DeriveIndexRange on mainnet P2WPKH via AccountUseCases.create - Bump @metamask/keyring-api to ^22.0.0 and @metamask/keyring-snap-sdk to ^8.0.0 - Add unit tests and changelog; release snap 1.11.0 Made-with: Cursor

socket-security · 2026-04-28T02:30:06Z

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff	Package	Supply Chain Security	Vulnerability	Quality	Maintenance	License
	@metamask/keyring-api@21.3.0 ⏵ 22.0.0				^-1
	@metamask/keyring-snap-sdk@7.1.1 ⏵ 8.0.0	⁺¹		⁺¹

View full report

gantunesr · 2026-04-28T21:27:50Z

@metamaskbot publish-preview

gantunesr · 2026-04-29T17:10:26Z

@metamaskbot publish-preview

github-actions · 2026-04-29T17:12:37Z

Preview builds have been published. See these instructions for more information about preview builds.

Expand for full list of packages and versions.

{
  "@metamask-previews/bitcoin-wallet-snap": "1.10.1-preview-fa702f3"
}

gantunesr · 2026-04-29T21:26:49Z

@metamaskbot publish-preview

github-actions · 2026-04-29T21:28:33Z

Preview builds have been published. See these instructions for more information about preview builds.

Expand for full list of packages and versions.

{
  "@metamask-previews/bitcoin-wallet-snap": "1.10.1-preview-7238495"
}

gantunesr · 2026-04-30T20:05:33Z

@metamaskbot publish-preview

github-actions · 2026-04-30T20:07:24Z

Preview builds have been published. See these instructions for more information about preview builds.

Expand for full list of packages and versions.

{
  "@metamask-previews/bitcoin-wallet-snap": "1.10.1-preview-112cb8e"
}

gantunesr · 2026-04-30T21:12:23Z

@metamaskbot publish-preview

gantunesr · 2026-05-06T21:04:42Z

@metamaskbot publish-preview

github-actions · 2026-05-06T21:06:29Z

Preview builds have been published. See these instructions for more information about preview builds.

Expand for full list of packages and versions.

{
  "@metamask-previews/bitcoin-wallet-snap": "1.10.1-preview-d66fa0d"
}

gantunesr · 2026-05-06T21:24:49Z

@metamaskbot publish-preview

github-actions · 2026-05-06T21:26:46Z

Preview builds have been published. See these instructions for more information about preview builds.

Expand for full list of packages and versions.

{
  "@metamask-previews/bitcoin-wallet-snap": "1.10.1-preview-811268a"
}

gantunesr · 2026-05-06T21:51:02Z

@metamaskbot publish-preview

github-actions · 2026-05-06T21:52:39Z

Preview builds have been published. See these instructions for more information about preview builds.

Expand for full list of packages and versions.

{
  "@metamask-previews/bitcoin-wallet-snap": "1.10.1-preview-e8b9ff2"
}

gantunesr · 2026-05-07T13:27:59Z

@metamaskbot publish-preview

github-actions · 2026-05-07T13:29:53Z

Preview builds have been published. See these instructions for more information about preview builds.

Expand for full list of packages and versions.

{
  "@metamask-previews/bitcoin-wallet-snap": "1.10.1-preview-063ba19"
}

gantunesr · 2026-05-07T15:56:54Z

@metamaskbot publish-preview

github-actions · 2026-05-07T15:58:57Z

Preview builds have been published. See these instructions for more information about preview builds.

Expand for full list of packages and versions.

{
  "@metamask-previews/bitcoin-wallet-snap": "1.10.1-preview-e706b82"
}

gantunesr · 2026-05-07T17:05:17Z

@metamaskbot publish-preview

cursor

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit b88ce08. Configure here.}

github-actions · 2026-05-07T17:07:12Z

Preview builds have been published. See these instructions for more information about preview builds.

Expand for full list of packages and versions.

{
  "@metamask-previews/bitcoin-wallet-snap": "1.10.1-preview-b88ce08"
}

gantunesr · 2026-05-08T00:41:19Z

@metamaskbot publish-preview

github-actions · 2026-05-08T00:43:06Z

Preview builds have been published. See these instructions for more information about preview builds.

Expand for full list of packages and versions.

{
  "@metamask-previews/bitcoin-wallet-snap": "1.10.1-preview-e83f11e"
}

gantunesr requested a review from a team as a code owner April 28, 2026 02:27

gantunesr marked this pull request as draft April 28, 2026 02:28

gantunesr changed the title ~~feat: implement keyring_createAccounts (MUL-1782)~~ feat: implement keyring_createAccounts Apr 28, 2026

cursor Bot reviewed Apr 28, 2026

View reviewed changes

Comment thread packages/snap/snap.manifest.json

gantunesr added 6 commits April 28, 2026 11:53

chore: update manifest

40ffbc1

chore: update manifest

0df7c66

chore: update shasum

e3948cf

chore: update CHANGELOG

94cfdd6

chore: update CHANGELOG

b2337de

fix: lint

6dac972

gantunesr added 5 commits April 28, 2026 17:30

chore: update manifest

ba86c3f

chore: update manifest

75cfc13

fix: revert version change

6a72002

fix: revert manifest change

401d822

chore: align keyring-api

fa702f3

gantunesr marked this pull request as ready for review April 29, 2026 17:11

gantunesr force-pushed the gar/feat/create-accounts branch from 7238495 to fa702f3 Compare April 30, 2026 16:14

gantunesr added 2 commits April 30, 2026 14:29

feat: speed optimization

deaea5a

feat: speed optimization

112cb8e

chore: add logs

38cc8b5

fix log

811268a

improve logs

e8b9ff2

gantunesr force-pushed the gar/feat/create-accounts branch from 8ac45b4 to e8b9ff2 Compare May 6, 2026 23:19

MetaMask deleted a comment from github-actions Bot May 6, 2026

add performance logs

063ba19

fix: remove event emission

e706b82

add internal batching

b88ce08

cursor Bot reviewed May 7, 2026

View reviewed changes

Comment thread packages/snap/src/handlers/KeyringHandler.ts Outdated

experiment

e83f11e

chore: remove logs

947d0ea

Uh oh!

Conversation

gantunesr commented Apr 28, 2026 • edited by cursor Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation

What changed

References

Uh oh!

socket-security Bot commented Apr 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

gantunesr commented Apr 28, 2026

Uh oh!

gantunesr commented Apr 29, 2026

Uh oh!

github-actions Bot commented Apr 29, 2026

Uh oh!

gantunesr commented Apr 29, 2026

Uh oh!

github-actions Bot commented Apr 29, 2026

Uh oh!

gantunesr commented Apr 30, 2026

Uh oh!

github-actions Bot commented Apr 30, 2026

Uh oh!

gantunesr commented Apr 30, 2026

Uh oh!

gantunesr commented May 6, 2026

Uh oh!

github-actions Bot commented May 6, 2026

Uh oh!

gantunesr commented May 6, 2026

Uh oh!

github-actions Bot commented May 6, 2026

Uh oh!

gantunesr commented May 6, 2026

Uh oh!

github-actions Bot commented May 6, 2026

Uh oh!

gantunesr commented May 7, 2026

Uh oh!

github-actions Bot commented May 7, 2026

Uh oh!

gantunesr commented May 7, 2026

Uh oh!

github-actions Bot commented May 7, 2026

Uh oh!

gantunesr commented May 7, 2026

Uh oh!

cursor Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions Bot commented May 7, 2026

Uh oh!

gantunesr commented May 8, 2026

Uh oh!

github-actions Bot commented May 8, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

gantunesr commented Apr 28, 2026 •

edited by cursor Bot

Loading

socket-security Bot commented Apr 28, 2026 •

edited

Loading