Skip to content

Skip the Generate Calibration Waypoints Objective in the config integration tests - #918

Open
fdavulcu wants to merge 1 commit into
mainfrom
test/skip-generate-calibration-waypoints
Open

Skip the Generate Calibration Waypoints Objective in the config integration tests#918
fdavulcu wants to merge 1 commit into
mainfrom
test/skip-generate-calibration-waypoints

Conversation

@fdavulcu

@fdavulcu fdavulcu commented Sep 9, 2026

Copy link
Copy Markdown

[written by AI]

Skips the Generate Calibration Waypoints Objective in the config integration tests. Each config's test runs every runnable Objective the system config resolves, and this one moves the arm and saves waypoints into the config's waypoint file. The entry is inert until the Objective ships in the base image.

…on tests

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
@fdavulcu fdavulcu added this to the 10.2.0 milestone Sep 9, 2026
@coderabbitai

coderabbitai Bot commented Sep 9, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Team

Run ID: d4e437df-78f9-4c3b-9118-890ac87b1726

📥 Commits

Reviewing files that changed from the base of the PR and between 5975b00 and dedb0c8.

📒 Files selected for processing (7)
  • src/april_tag_sim/test/objectives_integration_test.py
  • src/dual_arm_sim/test/objectives_integration_test.py
  • src/factory_sim/test/objectives_integration_test.py
  • src/grinding_sim/test/objectives_integration_test.py
  • src/hangar_sim/test/objectives_integration_test.py
  • src/kitchen_sim/test/objectives_integration_test.py
  • src/lab_sim/test/objectives_integration_test.py

Included review availability: 9 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 10 reviews per hour.


📝 Summary

Summary by CodeRabbit

  • Tests
    • Updated integration-test coverage across simulation environments to skip calibration waypoint generation where the required calibration resources are unavailable.
    • Clarified test expectations for hand-eye calibration objectives that depend on calibration waypoints and ChArUco detection.

Walkthrough

The integration tests for seven simulation packages now skip Generate Calibration Waypoints and update the rationale for skipping hand-eye calibration objectives that require calibration waypoints or ChArUco detection.

Changes

Integration test skip updates

Layer / File(s) Summary
Skip calibration-dependent objectives
src/*_sim/test/objectives_integration_test.py
The seven integration tests add Generate Calibration Waypoints to their skip lists and document the required generated calibration_* waypoints and ChArUco detection.

Suggested reviewers: shaur-k

Priority: ⬇️ Low

Merge Risk: ⚪ Minimal · up to dedb0

Headless simulation integration tests now exclude calibration waypoint generation alongside related calibration-dependent objectives, avoiding unsupported waypoint-writing behavior without changing production functionality.

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Human Review Check ✅ Passed PASS: The commit changes only seven test/objectives_integration_test.py files. It adds Generate Calibration Waypoints to existing per-simulation skip sets and updates comments. It does not change …
Description check ✅ Passed The pull request description directly describes the addition of Generate Calibration Waypoints to the integration-test skip lists. It also explains why the objective must be skipped.

Comment @coderabbitai help to get the list of available commands.

@fdavulcu
fdavulcu marked this pull request as ready for review September 9, 2026 13:33
@github-actions

github-actions Bot commented Sep 9, 2026

Copy link
Copy Markdown

MoveIt Pro Example WS - Objectives Integration Test Report

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant