-
Notifications
You must be signed in to change notification settings - Fork 12
Carry an offboard observation's frames through a shared-memory ring #736
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
v-positronic
wants to merge
16
commits into
offboard-unix-socket
Choose a base branch
from
offboard-frame-ring
base: offboard-unix-socket
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
bdb74f1
Carry an offboard observation's frames through a sealed shared-memory…
v-positronic 74df380
Answer the rules check on the frame ring
v-positronic a328cf8
Name the observation keys the tests use through `positronic.keys`
v-positronic b821294
Hold the frame ring's comments to the writing rules
v-positronic 1fbe5f3
Leave the ring's cross-component facts in the README alone
v-positronic 1fc6236
Cut every sentence the README already states as the contract
v-positronic d7146ef
Free a ring the server never took, and state only what `is_image` dec…
v-positronic bd3c59c
Point the inference guide at the ring's contract instead of restating it
v-positronic c07a95f
State two ring facts plainly
v-positronic a7a2cca
State the benchmark's own measure plainly
v-positronic a419a04
Wake the accept loop before the frame channel closes
v-positronic e53f69c
Declare a frame ring only where one can be built
v-positronic bcf9c06
Take the frame channel's socket from the server's own claim
v-positronic 9236851
Hold one ring per session, and bound what a handover can cost
v-positronic 118c952
Say why a host serves no ring, and free a ring that never finished
v-positronic 3d25949
Name the ring probe for its verdict, and let `close` outwait a handover
v-positronic File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rule stale-doc violated:
The frame-ring contract says the server keeps every mapping, but
FrameChannel._take_ringnow retains only the newestMappedRing; an older mapping survives only when a NumPy view still references itsmmap. Update this bullet to describe that ownership model so readers do not expect the channel itself to retain every historical mapping.AGENTS.md reference: AGENTS.md:L14-L22
Useful? React with 👍 / 👎.