Skip to content

fix(svelte): clear the hidden lint backlog, then un-skip the gate - #363

Merged
prisis merged 3 commits into
alphafrom
ci/302-unskip-lint-small
Aug 8, 2026
Merged

prisis merged 3 commits into
alphafrom
ci/302-unskip-lint-small

Conversation

@prisis

@prisis prisis commented Aug 8, 2026 •

Copy link
Copy Markdown
Member

What

@lunora/svelte's lint gate was reporting success after ~13 ms of doing nothing. Its project.json declared lint:eslint in nx's shape (executor + nested options.command), which vis does not read — it finds no top-level command, prints No command configured, and records a pass. The declared target shadowed the manifest script, so the package was never linted by the aggregate run that CI requires.

This clears the hidden backlog and deletes the block, in one commit, so the gate and the cleanup land together (plan 302 phase 6).

The findings

24 problems — 0 errors, 24 warnings, failing only because the manifest script carries --max-warnings=0. All in __tests__/, none in src/.

Rule Count Fix
vitest/require-mock-type-parameters 20 inline parameter annotations moved into the vi.fn<Signature>() type parameter
vitest/prefer-strict-equal 4 toEqual → toStrictEqual

Nothing disabled, no rule relaxed, no --max-warnings widened, no test removed. The style matches the precedent set by #343 for vue/auth line for line, and the sibling branch uses the same convention — one rule, one shape.

The four toStrictEqual swaps were each traced to the value's construction site rather than trusted from the autofix, since that matcher additionally checks undefined-valued keys, array sparseness and prototypes. All four actual values are plain literals or pass through by identity. toStrictEqual was already this package's convention — 50+ existing uses, including the identical assertion shape in subscription.test.ts; these four were the stragglers.

The old target could never have worked

Its command was eslint --config {workspaceRoot}/eslint.config.js ., and there is no root eslint.config.js in this repo — every package carries its own. Had vis ever honoured the block it would have died with ENOENT. It also dropped the --max-warnings=0 the manifest script carries.

Verification

  • pnpm --filter "@lunora/svelte" run lint:eslint / lint:types / test → clean, clean, 18 files / 98 passed
  • Control: origin/alpha's test files, restored against this branch's src/, also pass 98 — so nothing here is a test that only passes after the change
  • Gate canaries: an unused var took the gate from a 2 ms cached pass to a 4.6 s run failing with 4 errors; a single planted warning failed the gate on --max-warnings=0, which is the property the whole change exists to restore
  • vis run lint:eslint --query "project=svelte" → 4.7 s of real work, exit 0, No command configured gone
  • Repo-wide lint:eslint exit 0; lint:package-json clean

⚠️ Merge-order dependency with #364

That PR adds scripts/check-project-json-targets.js, whose KNOWN_UNMIGRATED allowlist contains packages/svelte — and the check fails on a stale entry as well as a missing one, by design, so an allowlist cannot outlive its fix.

This branch makes packages/svelte clean. Whichever of the two merges second must also empty that allowlist (new Map()), or pnpm run lint:project-json exits 1 on alpha. It runs as the first step of the Lint workflow's eslint job, so the failure lands inside a required check and reads as "svelte lint broken" when the real cause is a stale debt marker. This branch cannot fix it itself — the script does not exist on its base.

Review

Both thermo passes ran against the full branch diff. Bugs/security: clean, no findings at any actionable severity. Code quality: clean on its own merits, with the merge-order dependency above as the only blocker and two optional tidies (mutation.test.ts:12 and hydrate-preloaded.test.ts:15 declare fewer parameters than the methods they stand in for — harmless today, since toHaveBeenCalledWith is not parameter-typed in this vitest version, which was proven by probe; the second is pre-existing on alpha).

🤖 Generated with Claude Code

https://claude.ai/code/session_011sk9BLaUZDkPVAZ1sKhuDP

Summary by CodeRabbit

  • Chores
    • Removed the Svelte project’s ESLint linting tasks from the available project commands.

The package's `lint:eslint` target was declared in nx's shape (`executor` +
`options.command`), which vis reports as "No command configured" — and counts
as a pass. Deleting the block falls back to the manifest script, which carries
`--max-warnings=0`.

Clearing the backlog the gate was hiding: 20 `vitest/require-mock-type-parameters`
(inline parameter annotations moved into the `vi.fn<Signature>()` type
parameter) and 4 `vitest/prefer-strict-equal` (`toEqual` → `toStrictEqual`; all
four compare plain object literals, so the stricter matcher passes unchanged).

No rule disabled, no rule relaxed. Plan 302 phase 6.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_011sk9BLaUZDkPVAZ1sKhuDP
@netlify

netlify Bot commented Aug 8, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for lunorash ready!

Name Link
🔨 Latest commit 76e041c
🔍 Latest deploy log https://app.netlify.com/projects/lunorash/deploys/6a7735678305340008ee9051
😎 Deploy Preview https://deploy-preview-363--lunorash.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions

github-actions Bot commented Aug 8, 2026

Copy link
Copy Markdown
Contributor

Thank you for following the naming conventions! 🙏

@github-actions

github-actions Bot commented Aug 8, 2026

Copy link
Copy Markdown
Contributor

Thank you for confirming the Contributor License Agreement! 🙏

@coderabbitai

coderabbitai Bot commented Aug 8, 2026 •

Copy link
Copy Markdown

Review Change Stack

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (2)
  • packages/svelte/__tests__/hydrate-preloaded.test.ts is excluded by !**/__tests__/**, !**/*.test.ts and included by packages/**
  • packages/svelte/__tests__/mutation.test.ts is excluded by !**/__tests__/**, !**/*.test.ts and included by packages/**

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: e3f03f61-83e4-47c6-ad66-f3fc0e854b33

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Walkthrough

The Svelte project configuration now contains only package tags. The lint:eslint and lint:eslint:fix Nx targets were removed.

Changes

Svelte lint configuration

Layer / File(s) Summary
Remove Svelte ESLint targets
packages/svelte/project.json
The project configuration removes the lint:eslint and lint:eslint:fix targets, including their executor, command, caching, and input settings. It retains the package tags.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

  • anolilab/lunora#343: Removes the same ESLint Nx targets from analogous package configurations.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the Svelte lint-gate fix and hidden backlog cleanup, matching the primary change.
Description check ✅ Passed The description clearly explains the change, findings, verification, and merge dependency, although it omits the template headings and checklist.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch ci/302-unskip-lint-small

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codspeed

codspeed Bot commented Aug 8, 2026 •

Copy link
Copy Markdown

This PR has no benchmarks

⚠️ No benchmarks were detected in both the base of the PR and the PR.
Please ensure that your benchmarks are correctly instrumented with CodSpeed.

Check out the benchmarks creation guide


Comparing ci/302-unskip-lint-small (76e041c) with alpha (bd5216d)1

Open in CodSpeed

Footnotes

  1. No successful run was found on alpha (a0d1513) during the generation of this report, so bd5216d was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

Two mock signatures described `LunoraClient` methods with fewer parameters
than the methods take, so the package documented one method three ways.

`mutation.test.ts:12` declared zero parameters while the test it backs asserts
`toHaveBeenCalledWith(fnRef, args, { shardKey })` — the type said the opposite
of the assertion. `client.mutation` is `(function_, args, options?)`.

`hydrate-preloaded.test.ts:15` declared three parameters; `hydratePreloaded`
passes four (`subscribe(functionRef, args, callback, { shardKey })`), matching
the four already declared in `query.test.ts` and `subscription.test.ts`.

Neither was a live defect — `toHaveBeenCalledWith` is not parameter-typed in
this vitest version — but a future test asserting shardKey propagation would
have failed on tuple arity rather than on the behaviour it meant to check.
The zero-arity shorthand stays at `mutation.test.ts:24`/`:48`, which only care
about the returned promise.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_011sk9BLaUZDkPVAZ1sKhuDP
@codecov-commenter

codecov-commenter commented Aug 8, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (alpha@a0d1513). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff            @@
##             alpha     #363   +/-   ##
========================================
  Coverage         ?   67.00%           
========================================
  Files            ?       97           
  Lines            ?     3028           
  Branches         ?      713           
========================================
  Hits             ?     2029           
  Misses           ?      897           
  Partials         ?      102           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@prisis
prisis merged commit 6c009b9 into alpha Aug 8, 2026
12 of 14 checks passed
@prisis
prisis deleted the ci/302-unskip-lint-small branch August 8, 2026 13:55
prisis added a commit that referenced this pull request Aug 8, 2026
The svelte cleanup (#363) and the guard that allowlisted it (#364) both
landed, so the entry now describes an already-clean project. The check
fails on a stale entry by design, which is what makes an allowlist
unable to outlive its fix — so alpha went red the moment the second of
the two merged, and every open PR inherits it through refs/pull/N/merge.


Claude-Session: https://claude.ai/code/session_011sk9BLaUZDkPVAZ1sKhuDP

Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
@github-actions

github-actions Bot commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using our GitHub Discussions tab for questions.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Sep 8, 2026

This branch was previously deployed

1 inactive deployment
benchmarks — 76e041ce Deployed Aug 8, 2026 by prisis via Benchmarks #1543
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants