tests: fix binary test passing when failed and llvm-cov deprecated flag#165
Merged
artiepoole merged 4 commits intomainfrom Mar 30, 2026
Merged
tests: fix binary test passing when failed and llvm-cov deprecated flag#165artiepoole merged 4 commits intomainfrom
artiepoole merged 4 commits intomainfrom
Conversation
This was
linked to
issues
Mar 27, 2026
artiepoole
changed the title
Collaborator
Author
|
Marking ready to run the tests |
artiepoole
commented
Mar 27, 2026
There was a problem hiding this comment.
Pull request overview
Updates CI/Testflinger coverage scripts to keep llvm-cov env setup compatible with newer cargo-llvm-cov flags and to ensure the binary-device test job fails when the underlying test command fails.
Changes:
- Switch
cargo llvm-cov show-envinvocation from--export-prefixto--sh. - In the Testflinger binary device script, enable
pipefailand propagate the real test exit status even when piping throughtee.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
tests/coverage_test.sh |
Updates llvm-cov environment setup flag to a non-deprecated shell output mode. |
.github/testflinger-assets/test_binary_device_script.sh |
Fixes pipeline exit-code masking by capturing PIPESTATUS[0] and exiting with the test’s status. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
sets pipefail flag and catches sub-script return state disable -e only around coverage pipeline Signed-off-by: Artie Poole <stuart.poole@canonical.com>
artiepoole
force-pushed
the
artie/hotfix-integration-tests
branch
from
6841b36 to
d0ce10a
Compare
Collaborator
Author
|
Integrated copilot's suggestion of using +e/-e around the sub-script call |
Signed-off-by: Artie Poole <stuart.poole@canonical.com>
Collaborator
Author
|
The result of _run was not being propagated out. Trying to catch that in the TF script now |
Collaborator
Author
|
Thank worked. Patching the |
Signed-off-by: Artie Poole <stuart.poole@canonical.com>
Collaborator
Author
Sinan-Karakaya
approved these changes
Mar 27, 2026
talhaHavadar
requested changes
Mar 27, 2026
Collaborator
talhaHavadar
left a comment
talhaHavadar
left a comment
There was a problem hiding this comment.
just had a minor comment regarding journaling
talhaHavadar
approved these changes
Mar 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
adds error propagation up two levels from coverage test up to device script up to the tf job's _run command
fixes use of empty env var RUSTFLAGS